Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hope to add the "Refresh" button on the "Download" page. #4055

Closed
ghost opened this issue Apr 14, 2020 · 8 comments · Fixed by #4338
Closed

hope to add the "Refresh" button on the "Download" page. #4055

ghost opened this issue Apr 14, 2020 · 8 comments · Fixed by #4338
Labels
Good first issue Can be addressed without deep knowledge of the AntennaPod code. But exploring the code may be needed

Comments

@ghost
Copy link

ghost commented Apr 14, 2020

App version: 1.8.1 (Google Play)

Problem you are having:I hope my friends will add the "Refresh" button like "Queue", "Single Episode", "Subscription" page on the "Download" page.

Suggested solution:easy to use it

Screenshots / Drawings / Technical details:-
Markup_Screenshot_2020-04-14-19-00-30-534_AntennaPod

@ghost
Copy link
Author

ghost commented Apr 14, 2020

Thanks.

@ByteHamster ByteHamster added the Good first issue Can be addressed without deep knowledge of the AntennaPod code. But exploring the code may be needed label Apr 14, 2020
@Stephan-Codingmart
Copy link

@qiuyinjie Is this only for running tab ?

@Stephan-Codingmart
Copy link

@ByteHamster @qiuyinjie I have completed this one, please provide me the access for raise the pull request .

@Stephan-Codingmart
Copy link

@ByteHamster @qiuyinjie I have received the 403 while trying to push the code.

@ByteHamster
Copy link
Member

ByteHamster commented Apr 15, 2020

Hi, thanks for working on this. Sounds like you are trying to push directly to the AntennaPod repo. Github works a bit differently. You first create a fork of the repo and then push to your personal fork. Then you open a pull-request to add the changes to the main repo.

Have a look at this explanation: https://jarv.is/notes/how-to-pull-request-fork-github/

@Rogavactive
Copy link

I looked into this issue and provided retry option in my PR.

@pcsaunak
Copy link

Is this issue still open ?

@ByteHamster
Copy link
Member

@pcsaunak yes this PR is still open. @Rogavactive proposed a PR for retrying failed downloads (#2078), while this issue here is about a normal feed refresh button.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Good first issue Can be addressed without deep knowledge of the AntennaPod code. But exploring the code may be needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants