Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot add feed due to "Invalid type" #47

Closed
lapseofreason opened this issue Oct 23, 2012 · 12 comments
Closed

Cannot add feed due to "Invalid type" #47

lapseofreason opened this issue Oct 23, 2012 · 12 comments

Comments

@lapseofreason
Copy link

Many podcasts cannot be added to AntennaPod because it does not recognize their type. Here are some examples:

http://rss.sciam.com/sciam/60secsciencepodcast
http://rss.sciam.com/sciam/60-second-mind
http://rss.sciam.com/sciam/60-second-space
http://rss.sciam.com/sciam/60-second-health
http://rss.sciam.com/sciam/60-second-tech
http://www.risky.biz/netcasts/risky-business
http://www.risky.biz/netcasts/rb2

I have not had any problems with other podcasting applications, is it possible that AntennaPod is too strict about the format of the feed?

@ghost
Copy link

ghost commented Oct 25, 2012

I guess AntennaPod only supports rss 1.0 and rss 2.0, but those are rss 0.9.0 feeds...

@lapseofreason
Copy link
Author

You are right, they do indeed seem to be RSS 0.9.* feeds. This version still seems to be quite common though, at least a lot of my feeds are.

@danieloeh
Copy link
Member

In commit 38439db i have added support for RSS 0.9.1 and 0.9.2 feeds and the feeds you posted now seem to work. If you know of any more RSS 0.9.* feeds, you can post them too, if you want, so that i can add them to the testfile and make sure that they work.

@lapseofreason
Copy link
Author

Thanks a lot for the quick fix! I will check all feeds and see if any of them still don't work.

I had problems building it in Eclipse though, is it possible that the class de.danoeh.antennapod.R is missing in the repo?

@danieloeh
Copy link
Member

The R.java file should be generated automatically by eclipse. If it is not built automatically, there might be errors in the project or you might just have to clean the project first.

@lapseofreason
Copy link
Author

You are right, there were some errors in res/values-land/styles.xml and res/values/styles.xml because the style Theme.Sherlock.Light.ForceOverflow could not be found. Apparently, it is not available any more in newer versions of Android, so I replaced it with Theme.Sherlock.Light. Also proguard.cfg refers to some paths that are specific to your computer, which I replaced by relative paths.

I finally got it to build, but when I try to add the feed, the download does not complete but stays at 100% (or 400%-something for risky.biz) forever. I'm not sure if it's a problem with the code or just with my build though, if you have another build for me to test I would gladly do that.

@danieloeh
Copy link
Member

At the moment, i am using version 4.1.0 of that library because i haven't decided what to use instead of the ForceOverflow theme yet. And i should definitely change the proguard.cfg file (maybe those lines can be removed, i haven't tested it).

I uploaded an APK to the downloads section that contains the bugfixes for this issue and issue #48. With this APK the feeds worked on my device.

@lapseofreason
Copy link
Author

Thanks for the build, with Antennapod-issue47.apk most of the feeds do indeed work now, except the last two in the list above (risky.biz), which still result in "Invalid type".

@danieloeh
Copy link
Member

The links you posted are links to HTML pages. Have you tried the actual feed URLs?

http://risky.biz/feeds/risky-business
http://risky.biz/feeds/rb2

@lapseofreason
Copy link
Author

I think those are the actual feeds, at least those are the links to the feeds from the main website and firefox recognizes them as such. When looking at the page source they seem to be xml and the rss tag is present, but I'm not sure how to check whether they are valid.

@danieloeh
Copy link
Member

The links i posted are RSS feeds, but the ones in the first post were HTML pages:

http://risky.biz/feeds/risky-business <- Feed
http://www.risky.biz/netcasts/risky-business <- HTML

http://risky.biz/feeds/rb2 <- Feed
http://www.risky.biz/netcasts/rb2 <- HTML

In version 0.9.6 the feeds should work. If not, could you post the Android version that is running on your device?

"Valid" just means that the root of the XML is "rss" (or "feed" for Atom feeds). AntennaPod recognizes HTML sites as "Invalid feeds" because the root is "html". I admit that the error message AntennaPod is giving in this situation is not the most detailed one.

@lapseofreason
Copy link
Author

You are absolutely right about the feed, I missed the www in the address. I can confirm that the feeds now work in version 0.9.6, thanks a lot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants