Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Round widget #5465

Closed
iJahangard opened this issue Oct 12, 2021 · 13 comments
Closed

Round widget #5465

iJahangard opened this issue Oct 12, 2021 · 13 comments
Labels
Good first issue Can be addressed without deep knowledge of the AntennaPod code. But exploring the code may be needed Type: Feature request

Comments

@iJahangard
Copy link

Widgets letting us to access some stuff without opening the actual app
But without a good widget UI, I prefer don't use it

The current widget has Sharp corners,as you may know, these days rounded dialog and boxes are common
It seems that current widget has been carried on from Kit-Cat 👊😅

So may you do that little change?
(Actually this can be done with some other UI parts in the app too
Like the casts thumbnail in most left menu
They can be rounded, etc
Actually I want to say more about the UI but I'm afraid of to say ugh! We implement our app as we want! 😂)

@antennapod-bot
Copy link

Hi and thank you for writing this issue!

It looks like you did not follow our issue template. In case you accidentally deleted the template, you can find the version for bug reports here and the version for feature requests here. Please copy the matching template and then edit your post to follow the template. Please also make sure to use the search function to look for open and closed issues about the same topic.

In order to properly deal with the issue, we need the information requested in the template. Please note that dealing with duplicate issues and asking users to follow the issue template takes away a lot of time from the developers. That time can then not be spent to actually implement features.

@loucasal
Copy link
Contributor

@keunes Could this be a 'good first issue' too?

@keunes keunes added the Good first issue Can be addressed without deep knowledge of the AntennaPod code. But exploring the code may be needed label Apr 10, 2022
@ghost
Copy link

ghost commented Apr 17, 2022

Hey @keune assign this issue to me

@keunes keunes assigned ghost Apr 18, 2022
@keunes
Copy link
Member

keunes commented Apr 18, 2022

Hi @balgovind111, great that you're interested in contributing to AntennaPod! As mentioned on our website:

Have a look at our wiki; it contains handy info for contributors. You’ll find there, for example, information about the project’s code style and can learn how to make sure you get accredited for your work in the app. Last but not least: build instructions and info about debug logs.

@ghost
Copy link

ghost commented Apr 27, 2022

Hii @keunes What are the other medium to communicate with you.

@keunes
Copy link
Member

keunes commented Apr 28, 2022

Hi @balgovind111,
Best other way to reach out to the AntennaPod team is via our forum: https://forum.antennapod.org/g/Team

@antennapod-bot
Copy link

This issue has been mentioned on AntennaPod Forum. There might be relevant details there:

https://forum.antennapod.org/t/request-for-dev-help-quick-settings-tile/2252/3

@ByteHamster ByteHamster unassigned ghost Aug 7, 2022
@terminalmage
Copy link
Contributor

The widget as of 2.7.1 has rounded corners on my phone. This can probably be closed now.

@ByteHamster
Copy link
Member

I think it depends on the launcher. On Nova, it is rounded. On Trebuchet (standard LineageOS) and KISS, it isn't. What we send to the system isn't rounded (see also the preview when adding the widget)

@terminalmage
Copy link
Contributor

Oh, interesting.

@mueller-ma
Copy link
Contributor

I implemented rounded corners for the cover in the widget in #6483.

The corners of the widget could also be rounded: https://developer.android.com/develop/ui/views/appwidgets#rounded-corner
I followed this guide in a different app, but didn't find a way to provide a custom background color/transparency then.

@ridhi551
Copy link

ridhi551 commented Oct 7, 2023

I'm interested to fix the issue. But unable to view the project on Android Simulator because of failed Gradle sync. Gradle sync failed due to incompatible version of AGP (Android Gradle Plugin).
The project is using an incompatible version (AGP 7.4.0) of the Android Gradle plugin. Latest supported version is AGP 7.3.1
Needed help to resolve the issue.

@mueller-ma
Copy link
Contributor

I guess this issue can be closed as #6483 has been merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Good first issue Can be addressed without deep knowledge of the AntennaPod code. But exploring the code may be needed Type: Feature request
Projects
None yet
Development

No branches or pull requests

8 participants