Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sleep timer dialog broken in landscape mode in 3.0.0 Beta #6425

Closed
3 tasks done
JonOfUs opened this issue Apr 12, 2023 · 4 comments
Closed
3 tasks done

Sleep timer dialog broken in landscape mode in 3.0.0 Beta #6425

JonOfUs opened this issue Apr 12, 2023 · 4 comments
Labels
Type: Confirmed bug Bugs confirmed by a lead developer

Comments

@JonOfUs
Copy link
Contributor

JonOfUs commented Apr 12, 2023

Checklist

  • I have used the search function for open and closed issues to see if someone else has already submitted the same bug report.
  • I will describe the problem with as much detail as possible.
  • If the bug only to occurs with a certain podcast, I will include the URL of that podcast.

App version

3.0.0 Beta

Where did you get the app from

Google Play

Android version

10

Device model

Samsung Galaxy S9

First occurred

With 3.0.0 Beta

Steps to reproduce

  1. Intall 3.0.0 Beta
  2. Start playing an episode
  3. Bring device into landscape mode
  4. Open sleep timer dialog and start a sleep timer

Expected behaviour

Sleep timer dialog should be scrollable to show all buttons and checkboxes correctly

Current behaviour

Dialog is not scrollable, buttons are compressed (as in screenshot below).

Screenshot_AntennaPod

Edit: Probably since (and because of) the migration to Material3

Logs

No response

@JonOfUs JonOfUs added the Type: Possible bug Issues that seem to be a bug, but haven't been confirmed yet label Apr 12, 2023
@ByteHamster ByteHamster added Type: Confirmed bug Bugs confirmed by a lead developer Good first issue Can be addressed without deep knowledge of the AntennaPod code. But exploring the code may be needed and removed Type: Possible bug Issues that seem to be a bug, but haven't been confirmed yet labels Apr 12, 2023
@JAIVIGNESH2002
Copy link

Handled and made a PR.

@ShashidharYes
Copy link

ShashidharYes commented May 15, 2023

@JonOfUs, hey i would like to work on this issue.
If the issue is still not resolved

@keunes
Copy link
Member

keunes commented May 16, 2023

Hi @ShashidharYes
As you can see there already is a PR for this issue. So I would recommend looking at other good first issues.

Thanks for your interest!

@ByteHamster ByteHamster removed the Good first issue Can be addressed without deep knowledge of the AntennaPod code. But exploring the code may be needed label Sep 26, 2023
@ByteHamster
Copy link
Member

ByteHamster commented Dec 3, 2023

Was implemented in #6765, will be released in 3.3.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Confirmed bug Bugs confirmed by a lead developer
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants