Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert #6385 removing 'set lockscreen background' but only when not using Android Auto #6547

Open
3 tasks done
Matth7878 opened this issue Jul 17, 2023 · 10 comments
Open
3 tasks done
Labels
Needs: Decision Proposal and most arguments are clear, but needs a verdict. Type: Feature request

Comments

@Matth7878
Copy link

Checklist

  • I have used the search function for open and closed issues to see if someone else has already submitted the same feature request.
  • I will describe the problem with as much detail as possible.
  • This request contains only one single feature, not a list of multiple (related) features.

App version

3.1.0-beta2

Where did you get the app from

Google Play

Problem you may be having, or feature you want

PR #6385 removed the setting for 'set lockscreen background' because users where complaining on android auto to not having podcasts pictures.

Removing this settings means than on your normal day to day usage you no longer have a choice about it.
If like me AntennaPod is always running (except when system kill it) then your lockscreen is almost permanently changed with picture from the podcast you are currently listening.
Because of it I find it hard to read my lockscreen. Privacy wise I believe it could also be problematic to have a big picture on which you have no choice to be fully displayed on your lockscreen.

Suggested solution

Making the settings not work on Android auto is logical because there should be no reasons to have it off.
So It would be nice to be able to add back this setting but tweaking it to make it works only when not using Android Auto.

Screenshots / Drawings / Technical details

No response

@ByteHamster
Copy link
Member

So It would be nice to be able to add back this setting but tweaking it to make it works only when not using Android Auto.

That's the problem - this is not really possible. Either we tell the Android system about the image, or we don't. On Android 13, where the player controls are created by the Android system (not the AntennaPod notification), not telling the system about the image even removes it from the notification. That would lead to even more unexpected behavior

@Matth7878
Copy link
Author

IMHO the main usage which is not Android Auto should be favored and commit reverted. Maybe to avoid confusion settings could be also accessible from the player.

I am not a developer bit when I quickly google this link on developer.android.com made be think it was possible. ☹️

I maintain that not allowing to hide pictures on lock screen could be problematic if picture is nsfw. (Beside making it more difficult to read)
For those reading to avoid that turning off permanent play button on lock screen would work.

Should have posted this issue on the forum. Sorry about that. 😕

@ByteHamster
Copy link
Member

I think the only solution that is compatible with Android 13+ would be adding a setting to not show a cover at all. Not sure if we want that.

@ByteHamster
Copy link
Member

Sorry, I don't think there is a way to do this properly. Will close for now, but let's see how many complaints we get from users.

@keunes
Copy link
Member

keunes commented Aug 19, 2023

@Matth7878 You laid out some privacy, nsfw & legibility concerns for not being able to remove the cover image. Is always having the image also an issue for you in practice?

@Matth7878
Copy link
Author

@keunes it's not actually an issue for me but I am pretty sure it could be for some users. Personally my main issue is the lack of lock screen readability with some covers.

When I argued for this revert I realized that changing lock screen could be problematic privacy wise. Anybody can see your cover when screen turn on. It could because of a notification or someone turning it on. I guess it could be problematic if what you're listening is about religion, sexuality, controversial or whatever.
And cover could also be awful if you listen to something about animal protection, poverty in the world, or history... Wouldn't like to have those episodes covers being my lock screen...

Getting back to privacy player controls on lock screen could also be problematic. Ideally it should be possible to hide podcast name and episode name.
It would still possible for someone to trigger play on lock screen. So to be completely privacy wise it should possible to block starting to play if phone is locked.

That's way beyond the scope of my initial request and I am not really concerned with privacy on what I listen. Yet I think it could be a good thing and a plus if AntennaPod would improve on this.

@keunes
Copy link
Member

keunes commented Aug 19, 2023

player controls on lock screen could also be problematic. Ideally it should be possible to hide podcast name and episode name.

I guess that would be possible if we mark it as 'sensitive content'. But let's see if another user requests this.

@Russe
Copy link

Russe commented Sep 12, 2023

With AntennaPod's last update there's this blurred background image from current playing file on lockscreen now.
Before the update background was black, even when running AntennaPod.
I would like it very much to get rid of this, because I want to have a black background on my AMOLED display.

I don't know anything about android auto, hope this is the right thread for my issue.

Android 13
AntennaPod 3.1.0 (F-Droid)

@keunes keunes added Type: Enhancement Needs: Decision Proposal and most arguments are clear, but needs a verdict. labels Sep 12, 2023
@keunes keunes reopened this Sep 12, 2023
@Jolmberg
Copy link

Another vote for reverting this. I love Antenna Pod, but it's a podcast app, and I really don't see why it should get to change my background image at all. My phone probably has 50 other apps active at any given time and (thankfully) none of them try to do that.

@gsoros
Copy link

gsoros commented Oct 27, 2023

+1 for reverting. The background is distracting and sometimes it makes the clock illegible.

@AntennaPod AntennaPod locked and limited conversation to collaborators Oct 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Needs: Decision Proposal and most arguments are clear, but needs a verdict. Type: Feature request
Projects
None yet
Development

No branches or pull requests

6 participants