Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI does not fail if SpotBugs fails #6941

Closed
4 tasks done
ByteHamster opened this issue Feb 25, 2024 · 0 comments · Fixed by #6958
Closed
4 tasks done

CI does not fail if SpotBugs fails #6941

ByteHamster opened this issue Feb 25, 2024 · 0 comments · Fixed by #6958
Labels
Area: Project issue Type: Confirmed bug Bugs confirmed by a lead developer

Comments

@ByteHamster
Copy link
Member

Checklist

  • I have used the search function for OPEN issues to see if someone else has already submitted the same bug report.
  • I have also used the search function for CLOSED issues to see if the problem is already solved and just waiting to be released.
  • I will describe the problem with as much detail as possible.
  • If the bug only to occurs with a certain podcast, I will include the URL of that podcast.

App version

Where did you get the app from

Google Play

Android version

Device model

First occurred

No response

Steps to reproduce

No response

Expected behaviour

If something violates SpotBugs, the CI fails

Current behaviour

CI still shows green. Our current code now has a bunch of SpotBugs violations that were introduced by recent PRs because the CI did not catch them.

Logs

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Project issue Type: Confirmed bug Bugs confirmed by a lead developer
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant