Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fill empty space on translation and licences screen #7124

Closed
4 tasks done
flofriday opened this issue Apr 20, 2024 · 0 comments · Fixed by #7129
Closed
4 tasks done

Fill empty space on translation and licences screen #7124

flofriday opened this issue Apr 20, 2024 · 0 comments · Fixed by #7129

Comments

@flofriday
Copy link
Contributor

Checklist

  • I have used the search function for OPEN issues to see if someone else has already submitted the same feature request.
  • I have also used the search function for CLOSED issues to see if the feature was already implemented and is just waiting to be released, or if the feature was rejected.
  • I will describe the problem with as much detail as possible.
  • This request contains only one single feature, not a list of multiple (related) features.

App version

3.3.2f (develop branch)

Where did you get the app from

Other

Problem you may be having, or feature you want

The translation and licences screen both reserve empty space for an image but are never called with an URL to display such an image.

Suggested solution

Since no image will be displayed we don't need to reserve space here.

Screenshots / Drawings / Technical details

Screenshots (before/after):
image

Technical Details:
I already implemented the change in the SimpleIconListAdapter and will open the PR if the feature gets approved.
The image only is hidden if the imageUrl is null, which means that for the Contributors and the Special thanks screens nothing changes.

@flofriday flofriday added Needs: Triage The core team still needs to decide if this feature would get accepted Type: Feature request labels Apr 20, 2024
@keunes keunes removed the Needs: Triage The core team still needs to decide if this feature would get accepted label May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants