Change to Target URL Format #11

Johnng007 · 2022-04-06T10:50:49Z

(Thanks for sending a pull request! Please make sure you click the link above to view the contribution guidelines, then fill out the blanks below.)

What does this implement/fix? Explain your changes.

This fixes an issue with resolving IPs to hostnames using the conf.socket.gethostbyname(full_host) snippet.
Albeit i feel this task is not necessary as most hardened environments (like in OSCP & CTFs) purposely do not allow DNS resolving, users within a VPN environment would still experience this issue.

Owing to this i would like to make the following changes 
1. In the input for asset to scan users should enter only IP Address or Hostname without http://
2. Comment out full_ip = conf.socket.gethostbyname(full_host) in fullscan.py
3. Change nmap {full_ip} to  {full_host}
4. For nikto and dirsearch before {full_host} include http:// just to be http://{full_host}

…

Does this close any currently open issues?

Yes

…

Any relevant logs, error output, etc?

Traceback (most recent call last): File "/usr/local/bin/webmap", line 56, in <module> main() File "/usr/local/bin/webmap", line 48, in main conf.call_def(conf.full_scan) File "/home/kali/Desktop/TOOLS/WEB ATTACK/WebMap/conf/conf.py", line 80, in call_def func() File "/home/kali/Desktop/TOOLS/WEB ATTACK/WebMap/modules/fullscan.py", line 31, in full_scan full_ip = conf.socket.gethostbyname(full_host) socket.gaierror: [Errno -2] Name or service not known

…

Any other comments?

…

Where has this been tested?

Operating System: kali Linux …

Platform:Kali Linux Python 3 …

Target Platform: Ubuntu …

Python Version: Python 3 …

Install.sh and reopen() function

I've added more information so it can install on other linux distribution other than Debian flavours. Anything you can arrange. I've placed some comments on the file to be easy read

Update install.sh to install in other Systems

* remove chmod +x instruction from README as it's not needed (git keeps the permissions) * don't use `sudo` to execute the install script as it contains `sudo` commands * link to the MIT license in the README * replace tabs with spaces * remove trailing whitespaces * add newline at end of files In install.sh: * use a variable to hold the dependencies instead of repeating them * use the `--user` flag for pip install * use /usr/local/bin instead of /usr/bin for symlink * store dirsearch in ~/.opt instead of /opt: don't pollute the system with user software, don't use root to clone a git repository * use `$()` instead of backquotes * add quotes for variables * use env to find bash

Various fixes

commit-lint · 2022-04-06T10:50:52Z

Code Refactoring

Use the PEP8 naming convention (ff9e653)

Chore

release: 1.0.5 (e1c4043)

Contributors

luizmlo, Anteste, tfprelvas, NicolasCARPi

Commit-Lint commands

You can trigger Commit-Lint actions by commenting on this PR:

@Commit-Lint merge patch will merge dependabot PR on "patch" versions (X.X.Y - Y change)
@Commit-Lint merge minor will merge dependabot PR on "minor" versions (X.Y.Y - Y change)
@Commit-Lint merge major will merge dependabot PR on "major" versions (Y.Y.Y - Y change)
@Commit-Lint merge disable will desactivate merge dependabot PR
@Commit-Lint review will approve dependabot PR
@Commit-Lint stop review will stop approve dependabot PR

Johnng007

Resolving inability to scan IP based URLs

Johnng007 · 2022-04-06T10:54:23Z

modules/fullscan.py

+
+    conf.create_dir(full_output)
+
+    full_ip = conf.socket.gethostbyname(full_host)


#commenting out
#full_ip = conf.socket.gethostbyname(full_host)

Johnng007 · 2022-04-06T10:57:08Z

modules/fullscan.py

+        conf.full_host = None
+    elif gnome_installed:
+        conf.os.system(
+            f"gnome-terminal -- bash -c 'nmap -A {full_ip} -o \"{full_output}/nmap.txt\" && bash'"


#Going with Full Host Instead
f"gnome-terminal -- bash -c 'nmap -A {full_host} -o "{full_output}/nmap.txt" && bash'"

Johnng007 · 2022-04-06T11:01:58Z

modules/fullscan.py

+        conf.clear()
+
+        conf.os.system(
+            f"gnome-terminal -- bash -c 'python3 {conf.home}/.local/share/dirsearch/dirsearch.py -u {full_host} --simple-report=\"{full_output}/dirsearch.txt\" && bash'"


#Adding http in input
f"gnome-terminal -- bash -c 'python3 {conf.home}/.local/share/dirsearch/dirsearch.py -u http://{full_host} --simple-report="{full_output}/dirsearch.txt" && bash'"

Johnng007 · 2022-04-06T11:02:50Z

modules/fullscan.py

+        conf.clear()
+
+        conf.os.system(
+            f"gnome-terminal -- bash -c 'nikto +h {full_host} -output \"{full_output}/nikto.txt\" && bash'"


#Adding http in input
f"gnome-terminal -- bash -c 'nikto +h http://{full_host} -output "{full_output}/nikto.txt" && bash'"

Johnng007 · 2022-04-06T11:04:06Z

modules/fullscan.py

+        conf.clear()
+
+    else:
+        conf.os.system(f"nmap -A {full_ip} -o {full_output}/nmap.txt")


#Going with full_host instead
conf.os.system(f"nmap -A {full_host} -o {full_output}/nmap.txt")

Johnng007 · 2022-04-06T11:04:53Z

modules/fullscan.py

+            f"python3 ~/.local/share/dirsearch/dirsearch.py -u {full_host} --simple-report='{full_output}/dirsearch.txt'"
+        )
+
+        conf.os.system(f"nikto +h {full_host} -output {full_output}/nikto.txt")


#Going with full_host instead
conf.os.system(f"nikto +h http://{full_host} -output {full_output}/nikto.txt")

Johnng007 · 2022-04-06T11:08:16Z

modules/fullscan.py

+    print("===========================================================")
+
+    full_host = input(
+        conf.colored("\nEnter the target URL : ", "green", attrs=["bold"]))


#Change request parameter
conf.colored("\nEnter the target IP, Hostname or FQDN : ", "green", attrs=["bold"]))

Anteste · 2022-06-03T08:00:46Z

Hey John , thanks for the submiting this pull request.
Sorry if I didn't answer u earlier
You did a Good Job ;)

Merge pull request #11 from Anteste/1.x

luizmlo and others added 28 commits January 5, 2021 20:37

Added install.sh script

16f7337

Created reopen() function

d1896c1

Updated readme to use install script

7f548be

Merge pull request #5 from luizmlo/1.x

f90f53b

Install.sh and reopen() function

Clear function & reformat the code

7fe11ee

Fix some bugs

bbe2033

Fix report issues

6c564c7

Fix default report issues

8e12469

Update install.sh to install in other Systems

f06367d

I've added more information so it can install on other linux distribution other than Debian flavours. Anything you can arrange. I've placed some comments on the file to be easy read

Merge pull request #7 from tfprelvas/patch-1

a14b59a

Update install.sh to install in other Systems

1.0.3 - Major Update & New Features

79b852b

1.0.3 - Add requirements.txt

021c22b

1.0.3 - Update requirements.txt & Fix fullscan.py issues

dff87c6

v1.0.4 - Update requirements.txt & Add an Update Reminder

db44251

Update README.md

63fe001

v1.0.4 - Various fixes

12a4139

Various fixes

Create stale.yml

36dfc7b

Create label.yml

c36cb71

Add CONTRIBUTING.md

790babc

Update issue templates

a8636d1

Update issue templates

29b87f9

Create pull_request_template.md

5a8cba0

Update issue templates

34b2fb2

v1.0.4 - MIT License Header

c2ca3c7

v1.0.5 - Fix install.sh & requirements.txt bugs

17e0e64

refactor: Use the PEP8 naming convention

ff9e653

chore(release): 1.0.5

e1c4043

Johnng007 commented Apr 6, 2022

View reviewed changes

Anteste merged commit 43098bf into 1.0 Jun 3, 2022

Anteste added a commit that referenced this pull request Jun 3, 2022

Merge pull request #12 from Anteste/1.0

c3acdec

Merge pull request #11 from Anteste/1.x

Anteste mentioned this pull request Jun 3, 2022

Merge pull request #12 from Anteste/1.0 #13

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Change to Target URL Format #11

Change to Target URL Format #11

Johnng007 commented Apr 6, 2022

commit-lint bot commented Apr 6, 2022

Johnng007 left a comment

Johnng007 Apr 6, 2022

Johnng007 Apr 6, 2022

Johnng007 Apr 6, 2022

Johnng007 Apr 6, 2022

Johnng007 Apr 6, 2022

Johnng007 Apr 6, 2022

Johnng007 Apr 6, 2022

Anteste commented Jun 3, 2022


		conf.create_dir(full_output)

		full_ip = conf.socket.gethostbyname(full_host)

Change to Target URL Format #11

Change to Target URL Format #11

Conversation

Johnng007 commented Apr 6, 2022

What does this implement/fix? Explain your changes.

Does this close any currently open issues?

Any relevant logs, error output, etc?

Any other comments?

Where has this been tested?

commit-lint bot commented Apr 6, 2022

Code Refactoring

Chore

Contributors

Johnng007 left a comment

Choose a reason for hiding this comment

Johnng007 Apr 6, 2022

Choose a reason for hiding this comment

Johnng007 Apr 6, 2022

Choose a reason for hiding this comment

Johnng007 Apr 6, 2022

Choose a reason for hiding this comment

Johnng007 Apr 6, 2022

Choose a reason for hiding this comment

Johnng007 Apr 6, 2022

Choose a reason for hiding this comment

Johnng007 Apr 6, 2022

Choose a reason for hiding this comment

Johnng007 Apr 6, 2022

Choose a reason for hiding this comment

Anteste commented Jun 3, 2022