Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop micropipenv in favor of PEP-517 builds #32

Open
4 tasks
AntiCompositeNumber opened this issue Oct 23, 2021 · 0 comments
Open
4 tasks

Drop micropipenv in favor of PEP-517 builds #32

AntiCompositeNumber opened this issue Oct 23, 2021 · 0 comments
Labels
dependencies Pull requests that update a dependency file stalled

Comments

@AntiCompositeNumber
Copy link
Owner

With PEP-517, a package can install dependencies declared using pyproject.toml just using pip install .. However, Poetry 1.1 does not support installing editable packages this way (support is in the master branch, but hasn't been released). While just installing would work, any local changes would not be present in the installed version if not installed in editable mode. That could complicate debugging or cause confusion for a future maintainer. I don't think it's a good idea to install the package and then reference the source files directly. So this is stalled until Poetry releases a version with editable install support.

  • Change update.py
  • Change the Github workflow
  • Mark the scripts as scripts in pyproject.toml, and update the k8s files to uses the exported scripts
  • Update documentation
@AntiCompositeNumber AntiCompositeNumber added dependencies Pull requests that update a dependency file stalled labels Oct 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file stalled
Projects
None yet
Development

No branches or pull requests

1 participant