Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the management of files #6

Open
AntoineRondelet opened this issue Jul 2, 2018 · 1 comment
Open

Improve the management of files #6

AntoineRondelet opened this issue Jul 2, 2018 · 1 comment
Assignees

Comments

@AntoineRondelet
Copy link
Owner

For now the proof.json, vk.json, proof.raw and vk.raw are written at hardcoded path.
This makes usability pretty bad, and generates files where it shouldn't.
Using environment variables, and adding the path to the files as arguments of the functions generating the proof and the setup would be better

@AntoineRondelet AntoineRondelet self-assigned this Jul 4, 2018
@barryWhiteHat
Copy link

Yes this is a good idea. Its currently very messy how files are written. There is a bunch of other python clean ups that could be done also. Splitting snarkWrapper/deploy.py into a script to deploy the contract and interact with it and a python script to interact with libsnark. Also changing the way that imports happen. Currently i do a messy hack

import sys
sys.path.insert(0, '../snarkWrapper')

Which is not very nice. and probably not the python way to do this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants