Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace ureq with reqwest #30

Merged
merged 4 commits into from Oct 17, 2022
Merged

Replace ureq with reqwest #30

merged 4 commits into from Oct 17, 2022

Conversation

Celeo
Copy link
Contributor

@Celeo Celeo commented Oct 17, 2022

Happy Hacktoberfest!

A couple things to note:

  • I went with the blocking call as noted in the issue
  • I didn't touch the existing async functions

Fixes #28

Celeo
Celeo commented Oct 17, 2022
View reviewed changes
src/lib.rs Show resolved Hide resolved
Celeo and others added 3 commits October 17, 2022 13:12
@Celeo
Fix clippy lint
9f0c6c0
@AntoniosBarotsis
fmt
3b369ff
@AntoniosBarotsis @Celeo
Added default content type
789beed 
Co-authored-by: Matt Boulanger <mattboulanger@fastmail.com>
@AntoniosBarotsis
Copy link
Owner

Thanks a lot!

@Celeo
Copy link
Contributor Author

Celeo commented Oct 17, 2022

You betcha!

@AntoniosBarotsis AntoniosBarotsis merged commit ea3acb7 into AntoniosBarotsis:master Oct 17, 2022
@Celeo Celeo deleted the issue-28 branch October 17, 2022 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AntoniosBarotsis AntoniosBarotsis AntoniosBarotsis approved these changes

Assignees

@Celeo Celeo

Labels
enhancement New feature or request hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace ureq with reqwest
2 participants
@Celeo @AntoniosBarotsis