Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Style HTML output [HTML, CSS] #6

Open
AntoniosBarotsis opened this issue Sep 15, 2022 · 7 comments · May be fixed by #37
Open

Style HTML output [HTML, CSS] #6

AntoniosBarotsis opened this issue Sep 15, 2022 · 7 comments · May be fixed by #37
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest
Milestone

Comments

@AntoniosBarotsis
Copy link
Owner

AntoniosBarotsis commented Sep 15, 2022

The HTML output is generated by this function which currently does not include any CSS. Making some basic stylistic changes would be pretty cool.

Changes in the HTML itself are also welcome (such as including the post's description), the data you have available for each blog can be found here.

I don't have a very clear idea of what I'd want this to look like other than it being in dark mode, I like how Darkreader makes it look for instance. It would be nice to have a back-and-forth conversation about how this could look before you start implementing it!

Testing

Running cargo run should dump the generated HTML in the terminal which you can either save to a file and open in your browser or (if you are lazy like me) paste in something like https://html.onlineviewer.net/.

Edit: I might keep this open even after #37 is merged because I want to explore the idea of letting the user inject their own CSS through environment variables and/or predefined "themes".

@AntoniosBarotsis AntoniosBarotsis changed the title Style HTML output Style HTML output [HTML, CSS] Sep 15, 2022
@bryonye
Copy link

bryonye commented Sep 15, 2022

Hiya, I'm interested in working on this! I will probably be available to work on it in early October.
It might be worth implementing two or three themes (light, dark, and possibly high contrast) due to accessibility concerns. I'm not sure how this would work, but I can give it a shot at a later date if you're interested.

@AntoniosBarotsis
Copy link
Owner Author

AntoniosBarotsis commented Sep 15, 2022

Yes definitely wait until October starts so that the merge request actually counts for you!

Interesting idea creating 3 separate themes, that would definitely be more interesting. We could have one as the default and use environment variables to overwrite that selection. I'm not sure if you do Rust but if not I could definitely do the selecting part!

Edit: I mentioned this earlier but it would be nice to incorporate the optional descriptions into the output!

@AntoniosBarotsis
Copy link
Owner Author

By the way, I didn't make this too obvious but it would be nice if you included the descriptions as well in your output. Right now, these sometimes don't exist and sometimes they are more like the entire post instead of a summary but I have been thinking of limiting their length to make them more appropriate for this.

@AntoniosBarotsis AntoniosBarotsis added this to the v1.0 milestone Oct 10, 2022
@AntoniosBarotsis
Copy link
Owner Author

AntoniosBarotsis commented Oct 14, 2022

Hello @bryonye! Wondering if you are still working on this 😄

@AntoniosBarotsis AntoniosBarotsis added the enhancement New feature or request label Oct 17, 2022
@oliviacarino
Copy link
Contributor

oliviacarino commented Oct 19, 2022

@AntoniosBarotsis Hey! Can I implement the dark theme for this? bryonye could do the other 2 they mentioned (if they're cool with that)!

@oliviacarino
Copy link
Contributor

@AntoniosBarotsis Can I pick this up? Totally fine if not! I have experience with web dev stuff and could definitely put something simple and nice together :)

@AntoniosBarotsis
Copy link
Owner Author

AntoniosBarotsis commented Oct 22, 2022

I forgot to reply, yes! Are you going to tackle the entire issue since the other person doesn't seem to be responding?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest
Projects
Status: In Progress
3 participants