Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG Escape or sanitize assignment names #387

Closed
nickelpro opened this issue Sep 6, 2022 · 1 comment
Closed

BUG Escape or sanitize assignment names #387

nickelpro opened this issue Sep 6, 2022 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@nickelpro
Copy link

Describe the bug
Assignment names containing invalid characters for a GH repo name cause infinite problems. Discovered when I dared to put a colon in an assignment name, "Homework 1: Subtitle"

To Reproduce
Steps to reproduce the behavior:

  1. Create an assignment
  2. Change the assignment name to something containing an invalid character, like a colon
  3. Try to create a repo
  4. Everything burns

Expected behavior
Either an error when trying to save an invalid name, or a sanitization routine applied to assignment names prior to creating repos with them.

Screenshots
N/A

Desktop (please complete the following information):
N/A

Smartphone (please complete the following information):
N/A

Additional context
N/A

@github-actions
Copy link

github-actions bot commented Sep 6, 2022

Thank you for submitting an issue to Anubis! Please make sure that your issue is consistent with our contribution guidelines.

@wabscale wabscale self-assigned this Sep 7, 2022
@wabscale wabscale added the bug Something isn't working label Sep 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants