You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
My latest commit fixed some UB which materialized in the CI that this test here
ds2cps_ax_cps2ds_dependent2.thorin
failed to work sometimes on Windows.
Problem is: A literal 42:.Idx n doesn't make sense and should have been a type error (which it is now). It caused UB in some normalizers (which I have fixed).
One edge case is: 0:.Idx n. This kind of makes sense, as 0:.Idx 0 actually means 0:.Idx 2^64. So this literal is guaranteed to exist - but this is still kind of odd Oo Should we really allow that?
For now I disabled the test case above, as it makes use of this erroneous index.
My latest commit fixed some UB which materialized in the CI that this test here
failed to work sometimes on Windows.
Problem is: A literal
42:.Idx n
doesn't make sense and should have been a type error (which it is now). It caused UB in some normalizers (which I have fixed).One edge case is:
0:.Idx n
. This kind of makes sense, as0:.Idx 0
actually means0:.Idx 2^64
. So this literal is guaranteed to exist - but this is still kind of odd Oo Should we really allow that?For now I disabled the test case above, as it makes use of this erroneous index.
See also #101, #105.
tl;dr:
ds2cps_ax_cps2ds_dependent2.thorin
0:.Idx n
?The text was updated successfully, but these errors were encountered: