Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hogfather support #10

Closed
aledeg opened this issue Jul 9, 2020 · 8 comments
Closed

Add hogfather support #10

aledeg opened this issue Jul 9, 2020 · 8 comments

Comments

@aledeg
Copy link

aledeg commented Jul 9, 2020

This extension does not work with the latest dokuwiki version. It could be nice to either update it or at least warn users that it will break their install.

@Aorimn
Copy link
Owner

Aorimn commented Oct 13, 2020

I've not worked on this for a long time and don't have time to work on this, even though that shouldn't be that hard to port to a new DW version.

@danm14320
Copy link

the correction to be made is here (in action.php into tokenbucketauth)
public function register(&$controller)
by
public function register($controller)

it works perfectly for me

@aledeg
Copy link
Author

aledeg commented Dec 28, 2020

@danm14320 Maybe you could make a PR for that?

@danm14320
Copy link

in fact, in the sources here, the mod had already been fixed !

@Aorimn
Copy link
Owner

Aorimn commented Dec 30, 2020

Thanks for the bug report!
If it's already fixed, what made you think the extension didn't work with hogfather? Was it because you were working with a former version due to a DW upgrade?

@Aorimn
Copy link
Owner

Aorimn commented Jan 4, 2021

Closing in the meantime as this doesn't look like a bug in this plugin.

@Aorimn Aorimn closed this as completed Jan 4, 2021
@aledeg
Copy link
Author

aledeg commented Apr 20, 2021

Sorry for the noise. It seems to work fine now. I have no idea why though. :/

@asheenlevrai
Copy link

@danm14320

Do you have any time to look at this?

Thank you very much in advance for any help you could provide.

Best,
-a-

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants