Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python version parsing might be broken #22

Open
rsm31 opened this issue Dec 23, 2020 · 3 comments · May be fixed by #21
Open

Python version parsing might be broken #22

rsm31 opened this issue Dec 23, 2020 · 3 comments · May be fixed by #21
Assignees
@CaribouJohn

Comments

@rsm31
Copy link

rsm31 commented Dec 23, 2020

The Python installation detection in getPysysInterpreter() is looking for ersion in the output from the -V option to the Python interpreter. However, all the Python interpreters I have available produce output of the form Python x.y.z, e.g.

scott@orac:~/Projects$ python3 -V
Python 3.7.4
scott@orac:~/Projects$ python2 -V
Python 2.7.17

This is on WSL2 Ubuntu 18.04 and Raspberry Pi OS December 2020, using Pythons from the standard repos, so I don't think there is anything weird going on in my environment. I've opened PR #21 to (maybe) fix this and a related issue I found while trying to debug the first one.
@rsm31 rsm31 linked a pull request Dec 23, 2020 that will close this issue
Open
@CaribouJohn
Copy link
Contributor

CaribouJohn commented Dec 27, 2020 •
edited
Loading

Thanks Scott - i'll take a look - even better I spotted the pull :)

@CaribouJohn CaribouJohn linked a pull request Dec 27, 2020 that will close this issue
Make Python/PySys detection more reliable #21
Open
@CaribouJohn CaribouJohn self-assigned this Dec 27, 2020
@CaribouJohn
Copy link
Contributor

Just a note to say that I am passing this extension over to ApamaCommunity and as part of the handover someone else will be working though this to get some direct experience. Hopefully it will happen soon.

@rsm31
Copy link
Author

rsm31 commented Jan 16, 2021

Thanks John. Of course I'm happy to help, test, etc. if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@CaribouJohn CaribouJohn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make Python/PySys detection more reliable rsm31/pysys-vscode-extension
2 participants
@CaribouJohn @rsm31