Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor AccountAPI to pass through EIP-712 messages [APE-1103] #1508

Closed
banteg opened this issue Jun 28, 2023 · 2 comments
Closed

refactor AccountAPI to pass through EIP-712 messages [APE-1103] #1508

banteg opened this issue Jun 28, 2023 · 2 comments

Comments

@banteg
Copy link
Contributor

banteg commented Jun 28, 2023

this would allow providers like frame to display the message itself instead of just the hash

ape/src/ape/api/accounts.py

Line 51 in 0111c22

def sign_message(self, msg: SignableMessage) -> Optional[MessageSignature]:

@vany365 vany365 changed the title refactor AccountAPI to pass through EIP-712 messages refactor AccountAPI to pass through EIP-712 messages [APE-1136] Jun 28, 2023
@banteg banteg mentioned this issue Jun 28, 2023
Open
@fubuloubu fubuloubu changed the title refactor AccountAPI to pass through EIP-712 messages [APE-1136] refactor AccountAPI to pass through EIP-712 messages [APE-1103] Jun 28, 2023
@banteg banteg mentioned this issue Jun 28, 2023
Open
@antazoey
Copy link
Contributor

fixed by #1614

@antazoey
Copy link
Contributor

also i have never used frame but we have this now too which utilized the feature https://github.com/ApeWorX/ape-frame

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@banteg @antazoey