Skip to content
This repository has been archived by the owner on Jun 6, 2024. It is now read-only.

Allow to estimate gas cost on the devnet #52

Closed
ca11ab1e opened this issue Jul 2, 2022 · 1 comment · Fixed by #67
Closed

Allow to estimate gas cost on the devnet #52

ca11ab1e opened this issue Jul 2, 2022 · 1 comment · Fixed by #67
Assignees

Comments

@ca11ab1e
Copy link
Contributor

ca11ab1e commented Jul 2, 2022

It is possible to estimate gas cost from the devnet since several versions now, maybe could we remove that condition block then?

https://github.com/ApeWorX/ape-starknet/blob/573ffec279b513154a2240e8cae9720f082c1309/ape_starknet/provider.py#L163-L165

I guess it would unlock part of our tests at SithSwap.

Note: I open an issue because I tried removing that code, and it broke all tests:

BadRequest: HTTP error ocurred. Status: 500. Text: {"message":"Error at pc=0:6:\nGot an exception while executing a hint.\nCairo traceback (most recent call last):\nUnknown location (pc=0:1324)\nUnknown location (pc=0:1301)\nUnknown location (pc=0:611)\nUnknown location (pc=0:889)\n\nTraceback (most recent call last):\n  File \"<hint0>\", line 3, in <module>\nAssertionError: assert_not_zero failed: 0 = 0.","status_code":500}

Maybe opened PRs will help, especially #46? 🤔

@antazoey antazoey self-assigned this Jul 3, 2022
@0xSidius
Copy link

0xSidius commented Jul 4, 2022

to help guide @unparalleled-js for this feature:

exhibit A
image

exhibit B
image

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants