Skip to content
This repository has been archived by the owner on Jun 6, 2024. It is now read-only.

bug: Cannot invoke transactions on proxy contracts #8

Closed
antazoey opened this issue Apr 28, 2022 · 2 comments · Fixed by #17
Closed

bug: Cannot invoke transactions on proxy contracts #8

antazoey opened this issue Apr 28, 2022 · 2 comments · Fixed by #17
Labels
category: bug Something isn't working

Comments

@antazoey
Copy link
Contributor

antazoey commented Apr 28, 2022

When calling methods directly from their address on contracts that are proxies, things fail.

Example common proxy contracts in this ecosystem:

  • Accounts from Argent-X are proxies.
  • The ETH ERC20 contract is a proxy.

Both have issues on mainnet regarding ABIs. The logic for InvokeTransaction makes it difficult to use ABIs from the implementation address while invoking against the proxy address.

Discussions have been occurring with the starknet.py team about this as well as we figure out what to do.
software-mansion/starknet.py#128

@antazoey antazoey added the category: bug Something isn't working label Apr 28, 2022
@antazoey antazoey changed the title bug: Proxy contracts do not work bug: Cannot invoke transactions on proxy contracts May 3, 2022
@antazoey
Copy link
Contributor Author

can be worked on now! software-mansion/starknet.py#135

@antazoey
Copy link
Contributor Author

antazoey commented Jun 3, 2022

Actually - better yet - as of this work: ApeWorX/ape#750, proxies now work! I can check my ETH balance, etc. Woot woot.

  • Only thing that we need to do is bump ape, which will happen soon.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
category: bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant