Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PEP484 Annotations #33

Closed
iamdefinitelyahuman opened this issue Dec 31, 2019 · 0 comments
Closed

Add PEP484 Annotations #33

iamdefinitelyahuman opened this issue Dec 31, 2019 · 0 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@iamdefinitelyahuman
Copy link
Contributor

The Issue

The solcx codebase doesn't make use of PEP484 annotations. Adding them will make the code more readable and help prevent future bugs from being introduced.

Running MyPy with the following configuration should complete without errors.

[mypy]
disallow_untyped_defs = True
ignore_missing_imports = True
follow_imports = silent
files = solc/
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant