JSON compatibility check for schemaDependencies - Object

[hhkkxxx133]

Hello,

I am testing the JSON compatibility check for the object. There are several test cases for schemaDependencies of object type that are incorrect. From the code, it looks like one diff type compatibility is setting wrong: link

Let me know what do you think!

Tests:

1. should be forward compatible when adding schema dependencies

"original": {
  "$schema": "http://json-schema.org/draft-07/schema#",
  "type": "object",
  "properties": {
    "name": {"type": "string"},
    "address": {"type": "string"},
    "postal_code": {"type": "number"}
  },
  "required": ["name"]
},
"updated": {
  "$schema": "http://json-schema.org/draft-07/schema#",
  "type": "object",
  "properties": {
    "name": {"type": "string"},
    "address": {"type": "string"},
    "postal_code": {"type": "number"}
  },
  "required": ["name"],
  "dependencies": {
    "address": {"properties": {"city": { "type": "string" }}}
  }
}

2. should be backward compatible when removing schema dependencies

"original": {
  "$schema": "http://json-schema.org/draft-07/schema#",
  "type": "object",
  "properties": {
    "name": {"type": "string"},
    "address": {"type": "string"},
    "postal_code": {"type":  "number"}
  },
  "required": ["name"],
  "dependencies": {
    "address": {"properties": {"city": { "type": "string" }}}
  }
},
"updated": {
  "$schema": "http://json-schema.org/draft-07/schema#",
  "type": "object",
  "properties": {
    "name": {"type": "string"},
    "address": {"type": "string"},
    "postal_code": {"type":  "number"}
  },
  "required": ["name"]
}

3. should be forward compatible when schema dependencies key members are added

"original": {
  "$schema": "http://json-schema.org/draft-07/schema#",
  "type": "object",
  "properties": {
    "name": {"type": "string"},
    "address": {"type": "string"},
    "postal_code": {"type":  "number"}
  },
  "required": ["name"],
  "dependencies": {
    "address": {"properties": {"city": { "type": "string"}}}
  }
},
"updated": {
  "$schema": "http://json-schema.org/draft-07/schema#",
  "type": "object",
  "properties": {
    "name": {"type": "string"},
    "address": {"type": "string"},
    "postal_code": {"type":  "number"}
  },
  "required": ["name"],
  "dependencies": {
    "address": {"properties": {"city": { "type": "string"}}},
    "postal_code": {"properties": {"country": { "type": "string"}}}
  }
}

4. should be backward compatible when schema dependencies key members are removed

"original": {
  "$schema": "http://json-schema.org/draft-07/schema#",
  "type": "object",
  "properties": {
    "name": {"type": "string"},
    "address": {"type": "string"},
    "postal_code": {"type":  "number"}
  },
  "required": ["name"],
  "dependencies": {
    "address": {"properties": {"city": { "type": "string"}}},
    "postal_code": {"required": ["address"]}
  }
},
"updated": {
  "$schema": "http://json-schema.org/draft-07/schema#",
  "type": "object",
  "properties": {
    "name": {"type": "string"},
    "address": {"type": "string"},
    "postal_code": {"type":  "number"}
  },
  "required": ["name"],
  "dependencies": {
    "address": {"properties": {"city": { "type": "string"}}}
  }
}

[hhkkxxx133]

@jsenko Can you review this issue?

[jsenko]

Hi @hhkkxxx133 , I think you're right, the OBJECT_TYPE_SCHEMA_DEPENDENCIES_CHANGED diff type should be backwards compatible, otherwise the OBJECT_TYPE_SCHEMA_DEPENDENCIES_MEMBER_REMOVED does not make sense.