Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix workflow for building CLI images #1458

Closed
EricWittmann opened this issue Apr 22, 2021 · 7 comments · Fixed by #1517
Closed

Fix workflow for building CLI images #1458

EricWittmann opened this issue Apr 22, 2021 · 7 comments · Fixed by #1517
Assignees
Labels
Bug Something isn't working

Comments

@EricWittmann
Copy link
Member

We have a workflow that should be triggered (whenever a release is performed) to build our native CLI executables (one per operating system). This workflow is not being triggered for a release build (it should).

@EricWittmann EricWittmann added the Bug Something isn't working label Apr 22, 2021
@riprasad
Copy link
Member

@EricWittmann is this a high priority? If not, I would look into it after the downstream release activities are complete.

@EricWittmann
Copy link
Member Author

Not a high priority at all. Very low. :)

@EricWittmann
Copy link
Member Author

I have updated the workflows so that they can be triggered manually. I'm happy to live with that for the as long as needed. :)

@riprasad
Copy link
Member

This is interesting. I just mimicked the situation and created two workflows. one that creates a release and the other that should get triggered on the release event. It did not work. However, when I manually published a release using the Github UI, the workflow got triggered.

I will try to figure out why is this happening.

@EricWittmann
Copy link
Member Author

Very interesting! Is there a way to explicitly trigger/invoke a workflow from another workflow? We could chain them...

@riprasad riprasad linked a pull request May 24, 2021 that will close this issue
@riprasad
Copy link
Member

Very interesting! Is there a way to explicitly trigger/invoke a workflow from another workflow? We could chain them...

@EricWittmann There is definitely a way to trigger a workflow from another workflow. For more information, please refer https://docs.github.com/en/actions/reference/events-that-trigger-workflows#workflow_run

However, I was more curious in knowing the reason why the release-event trigger is not working. I tried creating a release using the Github UI directly and also via Github's REST API and surprisingly the workflows were getting triggered. Finally, I found this from the documentataion:-

Events triggered by the GITHUB_TOKEN will not create a new workflow run. This prevents you from accidentally creating recursive workflow runs. If you would like to trigger a workflow from a workflow run, you can trigger the event using a personal access token.

I immediately switched to using a PAT and Voila :)

@EricWittmann
Copy link
Member Author

Thanks!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants