-
Notifications
You must be signed in to change notification settings - Fork 250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create spi for rest client implementations #1480
Comments
@Apicurio/developers I have a question regarding the rest-client spi. How do we want to manage the dependency stuff, leveraging the user to include whatever dependency they want (no, I assume)? Using profiles to include one or another (e.g. the native profile will include the vertx impl)? Thoughts? |
probably worth asking Quarkus people. but my take is marking the client dependencies as "provided" so the user provides the dependency |
Agreed - it would be optimal if the vert.x client dependencies were "provided" and the default client impl should use the jdk client. That way if the user does nothing special, it will still work (using the built in java client) without needing any dependencies. To use another client (e.g. the vert.x one) they will need to set some kind of config property to switch to another client, and they will need to provide the appropriate dependencies. |
I think we agreed that if the user wants to use the vertx client they will need to pass a vertx instance as a parameter for creating the registry client object |
Closed by #1482 |
No description provided.
The text was updated successfully, but these errors were encountered: