Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle "required" fields in protobuf compatibility layer #2447

Closed
EricWittmann opened this issue Apr 14, 2022 · 1 comment
Closed

Handle "required" fields in protobuf compatibility layer #2447

EricWittmann opened this issue Apr 14, 2022 · 1 comment
Assignees
Labels

Comments

@EricWittmann
Copy link
Member

I am testing BACKWARD and BACKWARD_TRANSITIVE compatibility modes for PROTOBUF schemas (artifacts) and it looks like it is not working properly.

This is my use case:

  1. Register 1st version of protobuf artifact:
syntax = "proto2";

message ProtoSchema {
  required string message = 1;
  required int64 time = 2;
}
  1. Switch on the BACKWARD compatibility mode on that artifact
  2. Register 2nd version of protobuf artifact which is not backward compatible with 1st version (a required field is added):
syntax = "proto2";

message ProtoSchema {
  required string message = 1;
  required int64 time = 2;
  required string code = 3;
}
  1. Artifact gets registered without the error on compatibility rule check.
@EricWittmann
Copy link
Member Author

Fixed in #2439

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants