Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connect parameters not considered in cycleReferences cache #3606

Open
carlesarnal opened this issue Aug 28, 2023 · 2 comments
Open

Connect parameters not considered in cycleReferences cache #3606

carlesarnal opened this issue Aug 28, 2023 · 2 comments
Assignees
Labels
Bug Something isn't working

Comments

@carlesarnal
Copy link
Member

carlesarnal commented Aug 28, 2023

In AvroData with a struct like the following

{
        "type" : "struct",
        "fields" : [ {
          "type" : "int32",
          "optional" : false,
          "field" : "scale"
        }, {
          "type" : "bytes",
          "optional" : false,
          "field" : "value"
        } ],
        "optional" : true,
        "name" : "io.debezium.data.VariableScaleDecimal",
        "version" : 1,
        "doc" : "Variable scaled decimal",
        "parameters" : {
          "precision" : "10"
        },
        "field" : "VAL_F_10"
 }

There will be a cache hit in fromConnectContext.cycleReferences even if the parameters value is different. We must investigate using a different key (maybe the entire schema?).

@rk3rn3r
Copy link

rk3rn3r commented Feb 21, 2024

Hey @carlesarnal, may I ask you what's the status of this one? We are getting some more complaints about this issue from Debezium users and while I am working on a temporary workaround it would be good if that could be fixed soon. I might be able to look into it myself after I finished the workaround, but maybe you have a pointer for me? I think I look for fromConnectContext.cycleReferences() for the cache acccess?

@carlesarnal
Copy link
Member Author

Hey,

No status, sorry. This is acknowledged but we haven't had the time to go through it yet. What you mention is the perfect start, unfortunately, I don't have any other insight into this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants