Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve client credential server caching #4233

Closed
EricWittmann opened this issue Jan 22, 2024 · 0 comments · Fixed by #4452
Closed

Improve client credential server caching #4233

EricWittmann opened this issue Jan 22, 2024 · 0 comments · Fixed by #4452
Labels
area/auth Enhancement New feature or request

Comments

@EricWittmann
Copy link
Member

Feature or Problem Description

Currently we cache client credentials grant tokens (for basic auth) for a configurable period of time. If the cache time is greater than the expiration time of the token, then auth can fail.

Proposed Solution

Instead, we should cache the tokens based on their expiration. On a per-token basis. So instead of just a cache timeout, we intelligently remove tokens from the cache before they are set to expire.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/auth Enhancement New feature or request
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant