Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require images for ARM64 #1517

Closed
odidev opened this issue May 20, 2021 · 9 comments · Fixed by #1883 or #1905
Closed

Require images for ARM64 #1517

odidev opened this issue May 20, 2021 · 9 comments · Fixed by #1883 or #1905

Comments

@odidev
Copy link

odidev commented May 20, 2021

Hi Team,

I am trying to use apicurio-studio images in arm64 machine, but arm64 tag is not available for any of the images.

I have built API, UI, and WS images on the arm64 machine successfully. I have added buildx in GitHub actions but it requires the installation to be done from dockerfile to build target jars and run them.

Do you have any plans on releasing arm64 images?

If interested, I will raise a PR with buildx changes.

@EricWittmann
Copy link
Member

We don't have any current plans to release arm64 images. I'd be very happy to see a PR with the required changes.

@odidev
Copy link
Author

odidev commented Apr 1, 2022

@EricWittmann,

I have added a job for releasing docker images for arm64. Please have a look

Commit Link - odidev@3b57852

GHA Logs Link - https://github.com/odidev/apicurio-studio/runs/5770938137?check_suite_focus=true

DockerHub Images Links -

If you are fine with the above changes, I am happy to raise a PR.

@EricWittmann
Copy link
Member

@carlesarnal any thoughts on this?

@carlesarnal
Copy link
Member

I think this is an interesting idea. That said, I would have expected modifications to the current job to release the images for arm using buildx to build the images for both platforms instead of creating a fresh new job. @odidev please, open a PR, and we can continue the discussion there.

@EricWittmann
Copy link
Member

@riprasad Since you did this recently for Registry, could you implement it for Studio as well? :)

@odidev
Copy link
Author

odidev commented Apr 28, 2022

@EricWittmann

I have successfully built ARM64 image of apicurio-studio-auth on my local ARM64 machine and, I could see that the image for amd64 is released here but there is no specific release process mentioned. If I could get the release process for images, I would add ARM64 and raise PR for the same.

@EricWittmann
Copy link
Member

Sorry for the delay, @odidev and thank you for the offer. Right now the apicurio-studio-auth image is just released manually, because we don't release it very often.

So really we need to create a new separate GH workflow for this!

@riprasad wdyt? Easy to create a new standalone workflow for apicurio-studio-auth? I think it should initially be just manually triggered, but we can figure out an appropriate auto=trigger later.

The source for that image is here:

https://github.com/Apicurio/apicurio-studio/tree/master/distro/openshift/auth

@EricWittmann EricWittmann reopened this May 12, 2022
@riprasad riprasad linked a pull request May 17, 2022 that will close this issue
@riprasad
Copy link
Member

@odidev I was able to build the apicurio-studio-auth image in arm64, which is a bit surprising to me since the base image is only available for amd64. I thought it was also necessary for the base image to be available for the target platform.
Screenshot from 2022-05-17 14-21-11

@odidev
Copy link
Author

odidev commented May 17, 2022

@riprasad, As arm64 image of keycloack is not present on docker.io, we need to use the keycloak image available in quay.io.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants