-
Notifications
You must be signed in to change notification settings - Fork 489
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Description & Version incorrect #354
Comments
I must admit this is pretty shocking. :( I'll make this today's priority and it might warrant an emergency build... |
Note: it seems to be duplicating the most recent change, whatever it might be. Very bad. |
I am trying to understand too. Maybe, the problem is due to "openEditingSession" method in apis.service.ts? |
OK I've found and fixed the problem. Unintended consequence of another change. But basically I have an angular service shared across various editor components called CommandService. It's used to communicate when a sub-component causes a command (change) to be executed. But I wasn't resetting the service each time the editor was opened. The service exposes an Observer that the editor uses to listen for commands that need to be executed. Because the service wasn't reset between editing sessions, that same Observer was used every time. So the last executed Command was being dispatched to the new editor immediately when it subscribed. The solution is to reset the service when the editor is initialized. :) |
Great!!! Thx! |
Where is your commit? |
Just testing now. :) |
:) |
OK looks good now. Thanks for finding and reporting this! |
It's work! Thanks! |
Currently, after editing an API, if I edit another API, description & version fields are filled with the previous API. Furethemore, this incorrect data is stored in database because "onMessage" is executed (in EditApiDesignEndpoint)
Thx
The text was updated successfully, but these errors were encountered: