Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move components over from existing codebase #2

Closed
9 of 42 tasks
JamesDonnelly opened this issue Sep 10, 2018 · 1 comment
Closed
9 of 42 tasks

Move components over from existing codebase #2

JamesDonnelly opened this issue Sep 10, 2018 · 1 comment
Assignees
@JamesDonnelly
Labels
enhancement New feature or request

Comments

@JamesDonnelly
Copy link
Member

JamesDonnelly commented Sep 10, 2018 •
edited

Where this is now using JSS and React's Context API for theming, localisation and character support I can't just copy/paste over what is in the current codebase. Likewise for styling, where this is now using JSS and not Less the styles for each will need to be reconfigured.

  • Common components
    • AchievementSeries
    • Alert
    • AuthBox
    • Character
    • CharactersList
    • Content404
    • ContentHeading
    • Disqus
    • Error
    • FreeCompanyCrest
    • FreeCompanyName
    • IconWithDetails
    • Loading
    • ObtainMethodList
    • Panel
    • Popup
    • Progress
    • Search
    • Sprite
    • WikiTags
  • Layout
    • Container
    • Navigation
  • Navs (may be completely removed thanks to Character context)
    • Character
    • Default
  • Pages
    • Achievements
    • CharacterPrivacy (no longer required)
    • CharacterSelect
    • Connect
    • Home
    • List
    • OrchestrionRolls
    • Patches
    • Profile
    • Translate
    • Wiki
  • Routing
    • Page routes
    • Nav routes (may be completely removed thanks to Character context)
@JamesDonnelly JamesDonnelly added the enhancement New feature or request label Sep 10, 2018
@JamesDonnelly JamesDonnelly self-assigned this Sep 10, 2018
This was referenced Sep 10, 2018
Closed
Closed
@JamesDonnelly
Copy link
Member Author

The <Sprite /> component has been implemented as <Icon /> (5210340).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JamesDonnelly JamesDonnelly

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@JamesDonnelly