script doesnt check hash value anymore

[afterdelight]

Description

script doesnt check hash value anymore unlike previous version

Additional comments

Please add the feature back, so it can check for corrupt downloads. ty

[AlphaSlayer1964]

Yes it does. That feature was never removed.

[afterdelight]

i renamed .part download file to .zip while it only downloaded 10%. the next time i launched the script it skipped and said as already downloaded while the file in fact is corrupted.

[AlphaSlayer1964]

It removes the .part when the file is done and has the correct hash. If you change it manually it assumes it downloaded it correct already.

[afterdelight]

i exchanged and renamed the .part file with other .part file and it resumed download without checking the hash file . it will be corrupted when it completed. pls fix it.

[AlphaSlayer1964]

Why are you doing that?

[afterdelight]

because i want to check the script if it checking the hash or not?

[afterdelight]

i want to skip large psd file so I rename big psd .part file to .zip and then i realized it didnt check for hashes

[AlphaSlayer1964]

You can look at the code in the download function it checks the file hash when it is "completed" and removes the .part from the file name.

[afterdelight]

but it doesnt check hash when it resume download?

[AlphaSlayer1964]

Yes it does

[afterdelight]

uhh no it didnt i swapped the names with other file and it resume the download normally without error log

[AlphaSlayer1964]

I just tried your scenario and it says the file hash was incorrect.

[AlphaSlayer1964]

Please post logs

[afterdelight]

[afterdelight]

[AlphaSlayer1964]

These images do not show me anything.

[afterdelight]

real downlaoded part file 1,7 gb, fake replaced file 370mb. then when i resume it resume from 400mb which is from 370mb file. as you can see it didnt show error log

[AlphaSlayer1964]

Do you want it to check the hash before it resumes?

[afterdelight]

[afterdelight]

that was the real file it increased from 370mb to 540 mb after resume

[afterdelight]

yes, make it check hash file before it resume

[AlphaSlayer1964]

These images are not the debug.log

[AlphaSlayer1964]

yes, make it check hash file before it resume

What hash am I comparing it to then? The server only gives me a completed files hash.

[afterdelight]

then u lied about it checking hash before resume download wtf

[AlphaSlayer1964]

then u lied about it checking hash before resume download wtf

I never said that. When you said this:

but it doesnt check hash when it resume download?

I said yes because it checks when done. Why would I think before the resume starts? Thats not possible. The hash would always be wrong when trying to resume.

[afterdelight]

but when it trying to resume i didnt get haash error as the picture above

[AlphaSlayer1964]

When it has "completed" it will tell you if the hash is wrong.

[AlphaSlayer1964]

I can not do any more unless you post a debug.log file.

[afterdelight]

pls add skip word filter instead so i can skip big psd files

[afterdelight]

i dont have a debug log

[AlphaSlayer1964]

use --verbose

[AlphaSlayer1964]

pls add skip word filter instead so i can skip big psd files

Make a pull request

[afterdelight]

i dont know how to code sory

[afterdelight]

now it shows verbose log:

INFO:Downloading: [20220427] [FVBAH] [2] Tier 3 (PAGES HERE) .zip
DEBUG:Downloading from: https://kemono.party/data/44/f7/44f72820340a976ae166d91c973921bf993eba19b6829b1eb6e8efcf62583d22.zip?f=Tier 3 (PAGES HERE) .zip
DEBUG:Downloading to: kemono.party\gumroad\Aroma Sensei [4487698848613]\Pack 47 November 2021[20220427] [FVBAH] [2] Tier 3 (PAGES HERE) .zip.part
INFO:Trying to resuming partial download | Resume size: 539321792 bytes
WARNING:Failed to download: [20220427] [FVBAH] [2] Tier 3 (PAGES HERE) .zip | 416 Range Not Satisfiable | Assuming broken server hash value
ERROR:Incorrect amount of bytes downloaded | Something went so wrong I have no idea what happened

[AlphaSlayer1964]

I wouldn't use the main but stick to the releases.

[afterdelight]

wdym by that

[AlphaSlayer1964]

how did you download the downloader? from releases?

[afterdelight]

i downloaded it from hre
https://github.com/AlphaSlayer1964/kemono-dl/archive/refs/heads/main.zip

[afterdelight]

so i can get the latest release

[AlphaSlayer1964]

Use the latest release from releases not main. I can not grantee everything works in main. But either way the file would have never been marked as completed and had the .part removed.

[afterdelight]

i have a corrupted completed downloaded file before from old release. maybe its corrupted from the server, dunno havent checked it yet

[AlphaSlayer1964]

Annoyingly some of the hashes on kemonos website are wrong so it could be correct but the hash on the server is wrong.

[afterdelight]

no it was the .rar file is corrupted when i opened it not wrong hash file. it was completed already an the .part file has been removed

[AlphaSlayer1964]

send link to post

[afterdelight]

i forgot already, too many files. it was kidmo on gumroad. a few gb file size. but i forgot which file