#158947252 Implement feedback #41
Conversation
- Improve all tests coverages - Add CONTRIBUTING.md for contributors - Add animations to UI [Chore #158947252]
- Improve all tests coverages - Add CONTRIBUTING.md for contributors - Add animations to UI - Make tests more specific - Fix responsiveness issue - Make app more state dependent instead of reloading window - Replace placeholder texts with actual content [Chore #158947252]
|
|
||
| &.zoom-in { | ||
| &:hover { | ||
| animation-name: zoom-in; |
There was a problem hiding this comment.
Properties should be ordered animation-duration, animation-iteration-count, animation-name, animation-timing-function
| .animated { | ||
| &.bounce { | ||
| &:hover { | ||
| animation-name: bounce; |
There was a problem hiding this comment.
Properties should be ordered animation-duration, animation-name
| transform: scale(1); | ||
| } | ||
| } | ||
| .animated { |
There was a problem hiding this comment.
Rule declaration should be preceded by an empty line
| } | ||
| 50% { | ||
| transform: scale(1.1); | ||
| } |
There was a problem hiding this comment.
Rule declaration should be followed by an empty line
| @keyframes zoom-in { | ||
| 0% { | ||
| transform: scale(1); | ||
| } |
There was a problem hiding this comment.
Rule declaration should be followed by an empty line
| .row { | ||
| flex-direction: column; | ||
| align-items: center; | ||
| } |
There was a problem hiding this comment.
Rule declaration should be followed by an empty line
| } | ||
| // Overriding bootstrap | ||
| .row { | ||
| flex-direction: column; |
There was a problem hiding this comment.
Properties should be ordered align-items, flex-direction
| padding: 30px 20px; | ||
| display: flex; | ||
| flex-direction: column; | ||
| /* justify-content: center; */ | ||
| align-items: center; | ||
| font-size: 18px; | ||
| background-color: #242835; | ||
| color: white; |
There was a problem hiding this comment.
Color white should be written in hexadecimal form as #ffffff
Color literals like white should only be used in variable declarations; they should be referred to via variable everywhere else.
| padding: 30px 20px; | ||
| display: flex; | ||
| flex-direction: column; | ||
| /* justify-content: center; */ | ||
| align-items: center; | ||
| font-size: 18px; | ||
| background-color: #242835; |
There was a problem hiding this comment.
Color literals like #242835 should only be used in variable declarations; they should be referred to via variable everywhere else.
| @@ -1149,12 +1151,16 @@ body { | |||
|
|
|||
| // ABOUT US | |||
| .io-about { | |||
| height: 500px; | |||
| height: auto; | |||
There was a problem hiding this comment.
Properties should be ordered align-items, background-color, color, display, flex-direction, font-size, height, min-height, padding
Codecov Report
@@ Coverage Diff @@
## dev #41 +/- ##
======================================
Coverage ? 84.26%
======================================
Files ? 49
Lines ? 623
Branches ? 91
======================================
Hits ? 525
Misses ? 94
Partials ? 4
Continue to review full report at Codecov.
|
appcypher
changed the title
What does this PR do?
This PR adds component tests.
Description of Task to be completed?
How should this be manually tested?
To test the following features, you need to follow the following instructions here.
What are the relevant pivotal tracker stories?
158947252