Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR] Add a border to the selected Unsplash image. #5318

Open
LucasXu0 opened this issue May 13, 2024 · 3 comments · May be fixed by #5428
Open

[FR] Add a border to the selected Unsplash image. #5318

LucasXu0 opened this issue May 13, 2024 · 3 comments · May be fixed by #5428
Labels
good first issue for devs for the community members to claim good first issue for experienced devs for the experienced community developers to claim help wanted for the community members to claim

Comments

@LucasXu0
Copy link
Collaborator

Description

Currently, only the built-in images are given a border when selected. We should also add a border to selected Unsplash images.

Screenshot 2024-05-13 at 13 34 50 Screenshot 2024-05-13 at 13 33 39

Impact

Make the UI consistent.

Additional Context

Related file: https://github.com/AppFlowy-IO/AppFlowy/tree/main/frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/page_style/_page_style_cover_image.dart

@LucasXu0 LucasXu0 added good first issue for experienced devs for the experienced community developers to claim help wanted for the community members to claim good first issue for devs for the community members to claim labels May 13, 2024
@sudhar08
Copy link

Hey @LucasXu0 I can't understand what you are trying to do. so can you explain a bit more clearly it was very important to build a new feature for this community.

@Xazin
Copy link
Collaborator

Xazin commented May 19, 2024

Hey @LucasXu0 I can't understand what you are trying to do. so can you explain a bit more clearly it was very important to build a new feature for this community.

In the first image that Lucas attached to the issue report, under the Background image category, you see that the selected image has a blue border with some spacing and then the image.

Now in the second image attached, you see how selecting an Unsplash image looks, but if the unsplash image is already the selected image, there is no blue border indicating this.

This issue aims to address this discrepancy, by adding the same border from the first picture, to the unsplash image if it is the currently used (selected) one.

@sudhar08
Copy link

@Xazin Thank you for explaining

@AlainHsu AlainHsu linked a pull request May 28, 2024 that will close this issue
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue for devs for the community members to claim good first issue for experienced devs for the experienced community developers to claim help wanted for the community members to claim
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants