You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Create a markdown with an image hosted on a S3 with the token in url
Expected Behavior
We should have an image
Operating System
all
AppFlowy Editor Version(s)
2.3.2
Screenshots
No response
Additional Context
This is where the code is wrong
file: document_markdown_decoder.dart
line : 208
if (imageRegex.hasMatch(line.trim())) {
final filePath =extractImagePath(line.trim());
// checking if filepath is present or if the filepath is an image or notif (filePath ==null||!['.png', '.jpg', 'jpeg'].contains(p.extension(filePath))) {
returnparagraphNode(text: line.trim());
}
returnimageNode(url: filePath);
}
Here is a solution to fix this
final filePath =extractImagePath(line.trim());
if (filePath ==null) {
returnparagraphNode(text: line.trim());
}
final uri =Uri.parse(filePath);
final fileExtension = p.extension(uri.path);
// checking if filepath is present or if the filepath is an image or notif (!['.png', '.jpg', 'jpeg'].contains(fileExtension)) {
returnparagraphNode(text: line.trim());
}
The text was updated successfully, but these errors were encountered:
Bug Description
Markdown to document doesn't work on image with properties after extension.
When you have an image from for example firebase storage it has an url like
https://firebase.com/filename.jpg?alt=media&token=823990382903
How to Reproduce
Create a markdown with an image hosted on a S3 with the token in url
Expected Behavior
We should have an image
Operating System
all
AppFlowy Editor Version(s)
2.3.2
Screenshots
No response
Additional Context
This is where the code is wrong
file: document_markdown_decoder.dart
line : 208
Here is a solution to fix this
The text was updated successfully, but these errors were encountered: