Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Add Navigation Bar Translucency #743

Closed
wants to merge 5 commits into from

Conversation

AnuthaDev
Copy link
Contributor

Fixes #740
Added the option to have translucent navigation bars.

Currently the landscape layout is buggy

@paolorotolo paolorotolo added this to the 6.1.0 milestone Jan 26, 2020
@AnuthaDev AnuthaDev force-pushed the fixstuff branch 3 times, most recently from ed1bdd8 to 04fde0d Compare January 29, 2020 18:49
@AnuthaDev AnuthaDev marked this pull request as ready for review January 29, 2020 19:49
@AnuthaDev
Copy link
Contributor Author

Hey @cortinico So, I have pieced together this solution, it works!! But the code is ugly and I am not good at coding, so I hope you will be able to make something useful out of it

@cortinico
Copy link
Member

Thanks for the contrib @AnuthaDev
I'll try to get over this after the release.
In the meanwhile can I ask you to please make Travis green?

@cortinico cortinico self-requested a review January 30, 2020 00:39
@cortinico cortinico added the enhancement Issue/PR related to a new feature for the library label Jan 30, 2020
@AnuthaDev
Copy link
Contributor Author

Hey @cortinico Just a gentle reminder that you need to adopt this PR 😉 ('cuz I won't have access to my PC for several more months)

@cortinico
Copy link
Member

Closing this as the feature is not really requested as of today and it will introduce too much complexity on the API right now.

@cortinico cortinico closed this Jan 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Issue/PR related to a new feature for the library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add possibility to change navbar color per slide
3 participants