Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Main Thread Callbacks don't fire in Unity Editor #353

Closed
actopolus opened this issue Apr 6, 2024 · 2 comments
Closed

Main Thread Callbacks don't fire in Unity Editor #353

actopolus opened this issue Apr 6, 2024 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@actopolus
Copy link

MAX Plugin Version

6.4.1, 6.4.2

Unity Version

Any

Device/Platform Info

Unity Editor

Current Behavior

Ads callbacks that are routed through main thread don't fire in Unity Editor, but are working in build.

Expected Behavior

Ads callbacks are working in Unity Editor for testing purposes.

How to Reproduce

  1. Use described versions
  2. Listen callback OnAdHiddenEvent
  3. Invoke ShowRewardedAd or ShowInerstitialAd
  4. You will see logs about events but nothing will happens

Additional Info

There is logical error in the code, which creates MaxExecutor. Creation of MaxExecutor is placed between #if !UNITY_EDITOR and #endif.

You should clarify documentation that users of SDK rquired to invoke MaxEventExecutor.InitializeIfNeeded by self. Or just put this invokation in another place.

@actopolus actopolus added the bug Something isn't working label Apr 6, 2024
@JonathanLiuApp
Copy link
Contributor

@actopolus Thank you for bringing this to our attention. For now please call MaxEventExecutor.InitializeIfNeeded(). We are working on a fix and will update here when it is live.

@JonathanLiuApp
Copy link
Contributor

We've released a fix for this in the latest version of our plugin (6.4.3).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants