Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small adjustment to the Spinner. It looks better if having 12 rectangles instead of 10. #8

Open
wants to merge 26 commits into
base: master
Choose a base branch
from

Conversation

phuhuynh2411
Copy link

I made a small adjustment to the Spinner as below

  • Add two more rectangle to look similar to the iOS native Spinner
  • Put it inside a ZStack view to centralize the Spinner
  • Increase/Decrease the size of the Spinner based on its parent frame.

spinner_adjustment

@AppPear
Copy link
Owner

AppPear commented Apr 26, 2020

I think you might have commited a lot more then adding 2 rectangles, I'm afraid you have to cherry pick the right commit so I could merge it

@phuhuynh2411
Copy link
Author

I think you might have commited a lot more then adding 2 rectangles, I'm afraid you have to cherry pick the right commit so I could merge it

I don't have a write permission, so I cannot do the git-cherry pick. Perhaps, can you do it? Here is the right commit hash cbe4e32

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants