Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix JSP compilation under Java 8 #2632

Merged
merged 2 commits into from Jan 11, 2018
Merged

Fix JSP compilation under Java 8 #2632

merged 2 commits into from Jan 11, 2018

Conversation

cdonati
Copy link
Member

@cdonati cdonati commented Dec 20, 2017

This replaces the 1.8.4 JSP jar with the one included in the 1.9.44 SDK.

@cdonati
Fix JSP compilation under Java 8
da81ad5 
This replaces the 1.8.4 JSP jar with the jar included with the
1.9.44 SDK.
@cdonati
Remove existing Java SDK when rebuilding AppScale
3483e70 
This prevents older, conflicting jars from persisting through
upgrades.
@cdonati
Copy link
Member Author

cdonati commented Dec 20, 2017

https://ocd.appscale.com:8080/job/Daily%20Build/4466/

@cdonati cdonati mentioned this pull request Jan 4, 2018
Merged
@cdonati
Copy link
Member Author

cdonati commented Jan 11, 2018

Demo:
AppScale/hawkeye#129 against master: https://ocd.appscale.com:8080/job/Hawkeye/12957/
Against branch: https://ocd.appscale.com:8080/job/Hawkeye/12956/

@obino obino merged commit 1021e19 into AppScale:master Jan 11, 2018
@cdonati cdonati deleted the jsp-jar branch January 11, 2018 03:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@obino obino obino approved these changes

@tmarballi tmarballi tmarballi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@cdonati @obino @tmarballi