Fix parsing issues #47
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 13, 2021 10:46
Yarn.lock entries like this: ms@2.1.2, ms@^2.1.1, ms@^2.1.2: Would cause off-by-one errors, incorrectly attributing the version of the comma-delimited strings to packages lexically below this line.
Yarn lock entries of the form:
---
"@apollo/client@^3.1.5":
version "3.2.5"
integrity sha512-zpruxnFMz6K94gs2pqc3sidzFDbQpKT5D6P/J/I9s8ekHZ5eczgnRp6pqXC86Bh7+44j/btpmOT0kwiboyqTnA==
dependencies:
"@graphql-typed-document-node/core" "^3.0.0"
...
---
were being parsed incorrectly. This change correctly identifies the
group, name, and version for these entries, and also accounts for
optional surrounding quotes.
|
This is a partial fix for #45. (There remains buggy behavior when |
|
oh nice PR! I will take this and include other changes related to multiple entries appearing in the lock file. I will also change the integrity to use sha512. |
|
Thanks, @prabhu! Most excellent. |
|
@prabhu I believe this PR can be declined, as the above behaviors were addressed separately and no longer appear to be problematic as of: |
|
Thanks mate! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@prabhu This attempts to fix two parsing issues, one related to comma-delimited package declarations, and the other related to "@-scoped" packages. I believe this minimal yarn.lock snippet demonstrates both edge cases here: