Skip to content
This repository has been archived by the owner on Aug 31, 2022. It is now read-only.

Task 'assembleRelease' not found in root project 'application icon'. #6

Closed
pierre-gancel opened this issue Jan 20, 2021 · 9 comments
Closed
Assignees

Comments

@pierre-gancel
Copy link

all was working well while debuggin on macos,
encountered this error while trying to launch the app on android,
error disappeared when I remove pal from the .yaml

Global feedback however is great,
You are building a fantastic tools guys !

@g-apparence
Copy link
Contributor

Hello, Thank you for reporting it!
It's an asset error (Pal icon) that seems not available on android. Will try to reproduce and fix this asap.

Thank you for your feedback, that's really encouraging!
Don't hesitate to suggest any features.

@g-apparence g-apparence self-assigned this Jan 27, 2021
@ghost
Copy link

ghost commented Jan 29, 2021

Hi @pierre-gancel do you have an example to reproduce this error ?

@pierre-gancel
Copy link
Author

problem indeed comes from the application_icon-1.0.0 in my .pub-cache,
It is triggered when I use PAL, but could it be due to something else ?

Screenshot 2021-02-01 at 20 40 09

.pub-cache/hosted/pub.dartlang.org/application_icon-1.0.0/android/src/main/kotlin/de/ju/application_icon/AppIconLoader.kt:
(71, 16): Type mismatch: inferred type is Drawable? but Drawable was expected

@ghost
Copy link

ghost commented Feb 2, 2021

Thanks for your answer, it's seem to be an issue with the application_icon library which is used in Pal.

I can't reproduce this error on a blank new project, maybe there is a library conflict in your project ? Maybe you can try to remove some dependencies in your project until the error disappear to check if this is a conflict error.

For the moment, I suggest you to raise an issue on the application_icon repo 👍.

@pierre-gancel
Copy link
Author

Thanks, yes done, will see.
I will revert if no reply in a few days/weeks,
Why not consider embedding this into Pal to keep it under hand ?

@g-apparence
Copy link
Contributor

You are right, as for first release we used some plugins to reduce developments.
Now we got some majors goals for the next release. Reducing the number of external dependencies(like application_icon) is now critical.
The next release is on a big backend migration (we migrated our data to cassandra)... and plenty of cool features for the editor mode. We will try to include this ASAP.

@ueman
Copy link

ueman commented Feb 6, 2021

I've just fixed ueman/application_icon#5.
Your users have to run pub upgrade and it should work again.

@g-apparence
Copy link
Contributor

Wow thank you, that's really kind of you!
Did you migrate to null safety?
We also have to migrate to null safety soon.

@ueman
Copy link

ueman commented Feb 6, 2021

Not yet, but it shouldn't be too hard as it not much code. I would gladly accept a PR if you are open to that. The native side is already null safe because auf Swift and Kotlin.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants