Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow solid background color for ABKFeedNavigationBar #68

Closed
ldiqual opened this issue May 16, 2016 · 11 comments
Closed

Allow solid background color for ABKFeedNavigationBar #68

ldiqual opened this issue May 16, 2016 · 11 comments

Comments

@ldiqual
Copy link

ldiqual commented May 16, 2016

I'm trying to set a solid background color for ABKFeedNavigationBar. All I could come up with is this:

ABKFeedNavigationBar {
    background-tint-color: #3FCF7F;
    background-color: #3FCF7F;
}

image

Is there a way to make the navigation bar opaque with a solid green at the moment? Thank you :)

@Wenzhi
Copy link

Wenzhi commented May 16, 2016

Hi @ldiqual,

If you are using a non-navigation context, including generic, modal and popover contexts, you can make the navigation bar look solid by setting the translucent property:

ABKFeedViewControllerGenericContext *newsFeed = [[ABKFeedViewControllerGenericContext alloc] init];
[newsFeed.navigationBar setTranslucent:NO];

Please let us know if it doesn't work for you, or if you have any other questions.

Thanks,
Wenzhi

@ldiqual
Copy link
Author

ldiqual commented May 17, 2016

@Wenzhi I'm not initting the context myself, I'm assuming it just auto-creates itself whenever an inapp notification comes through. Is there a way to set this globally?

@Wenzhi
Copy link

Wenzhi commented May 17, 2016

@ldiqual, have you tried [[UINavigationBar appearance] setTranslucent:NO]?

@ldiqual
Copy link
Author

ldiqual commented May 17, 2016

@Wenzhi That would modify the appearance of all navigation bars, I want to apply it only to AppBoy's newsfeed.

@Wenzhi
Copy link

Wenzhi commented May 18, 2016

Hi @ldiqual,

Since the class for the feed navigation bar, ABKThemableFeedNavigationBar, isn't public, it’s not clear there’s a very clean, simple way to do this. Instead of suggesting possibly fragile workarounds, we’d like to plan a more generic way of providing this functionality. However, we don’t have a clear timeline for that now. Any sense of how urgent and how high priority this is for you would be appreciated as we strategize enabling this functionality.

Please let us know any further comments/questions.

Thanks,
Wenzhi

@ldiqual
Copy link
Author

ldiqual commented May 18, 2016

@Wenzhi This is not urgent for us. Just let us know whenever it can be done :) Thanks for the followup!

@ldiqual
Copy link
Author

ldiqual commented Sep 13, 2016

@Wenzhi Any update on this?

@briancaw
Copy link
Contributor

Hi @ldiqual

We haven't been able to execute on this just yet, but with iOS 10 stuff slowing down we'll aim to prioritize it in the near future.

Thanks very much for your patience,
Brian

@ldiqual
Copy link
Author

ldiqual commented Nov 14, 2016

@Wenzhi Bump on this. Still not urgent, but it seems that a quick fix from your side could be to make ABKThemableFeedNavigationBar public? Let me know.

@Wenzhi
Copy link

Wenzhi commented Feb 25, 2017

Hey @ldiqual,

Thanks for your suggestion and sorry for such a late reply! We just released SDK 2.26.0 and made the related classes public in the release. We also have the sample code here for how to set the News Feed navigation bar background color to be opaque.

Please let us know if it does not work for you, or if you have any other questions or issues!

Thanks,
Wenzhi

@Wenzhi
Copy link

Wenzhi commented Mar 3, 2017

Hey @ldiqual,

I'm going to close this issue, assuming the latest SDK solved it. If you still see the issue happen or have any questions, please feel free to re-open this.

Thanks,
Wenzhi

@Wenzhi Wenzhi closed this as completed Mar 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants