Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve backend of Configuration GUI #1189

Open
tomcw opened this issue Feb 26, 2023 · 3 comments
Open

Improve backend of Configuration GUI #1189

tomcw opened this issue Feb 26, 2023 · 3 comments

Comments

@tomcw
Copy link
Contributor

tomcw commented Feb 26, 2023

Now that all cards (in slots 0 to 7) exist as C++ classes, then the backend of the GUI's config can be improved:

From #978 (comment), I said:

I know that a better way of supporting this GUI configuration is to create copies of the card objects for all the slots, then let the user configure them (eg. insert images into drives attached to a slot-5 card). Then if the user cancels, just delete the objects. And if the user OK's the config, then use these new objects and delete the old ones.

See also #1056 (comment) where I talk about how the Configuration GUI for Disk & Harddisk being different to the other cards.

@Michaelangel007
Copy link
Contributor

@tomcw Couple of semi-related questions:

  1. How hard is it to extend the GUI config dialog box?
  2. What are we using to compile the .rc file? Did MS drop support for the resource compiler?

I've been meaning to add a Debug tab to the Configuration panel but wasn't sure what the state of the .rc stuff was.

@tomcw
Copy link
Contributor Author

tomcw commented Mar 26, 2023

Hi Michael,

  1. Currently the GUI config is "at capacity" - see Improve the Configuration GUI #853, where this issue tracks requests to improve this GUI.
  2. Yes - still using the resource compiler.

If you add a new Debug tab, then depending on the width (literally the pixel width of the word "Debug"!) it could result in 2 rows of tabs, which I really don't like (IMO it's confusing when the row of tabs switches from top to bottom or vice versa).

Probably the workaround is to make all the property sheet pages slightly wider so this doesn't happen. Try it and see.

@Michaelangel007
Copy link
Contributor

Thanks for the info. Been busy with debugger + disk QoL. Hoping to get a chance to play around with test driving a wider GUI dialog next month.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants