New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TV Emulation doesn't have accurate colors #502
Comments
Source 2aLet's explicitly render these 14 "fake" HGR colors sorted by hue:
1.25 TV mode1.26 TV modeThe vertical mixing of two adjacent scanlines looks worse in 1.26 then 1.25. Now instead of having a full 256*256 lookup table, we should be able to get with a much smaller table.Why? If we treat the HGR screen as only producing the valid 16 GR / DHGR colors we only need to have a [16][16] mixing table. We still need to work out how the bits need to be mixed. i.e. Do we take the top 4 bits of RGB ? SolutionsWe can either:
Which one is more accurate vs faster is TBD. |
Updated all images to be correct. TL:DR;
For 1.27 we want to aim more in the middle. Unanswered questions:
Let's suppose we want to generate TV mode for lines N, and N+1
Does it blend? There are multiple ways we can blend: Blend 1
Blend 2
Blend 3line1 = A/4 + B/2 + C/4 |
1.25 TV mode colors are TOO solid
Agreed.
1.26 TV mode colors are TOO pixelated
The AppleWin 1.26 screenshots you have above are actually in Color Monitor
mode.
Shouldn't you be comparing Color TV mode?
(This is accurate as to how I remember yellow looked in RGB and PAL
composite.)
Cheers,
Nick.
|
If we use a naive bicubic down-sample Program 2 TV mode: .. 50%: ... 25%: And then bicubic re-up-sample back up to 560px, we get these solid colors: We get similar results if we bilinear downsample / upsample monitor mode: ConclusionA naive re-sampling matches the hues of the actual TV pretty good. |
Let's convert program 2 from HGR to GR: Source 2b
OutputI've set the GR colors that don't match the fake HGR colors as black: Monitor ModeTV Mode |
@sicklittlemonkey Thanks Nick - - images should be correct now. Can you verify please? Thanks |
Disk image (ProDOS |
Thanks for posting this Michael! I am using colors affected by this issue extensively in Nox Archaist. |
No prob Mark. Updated comment 1 with extra information -- yellow, and and Composite-to-VGA adapter/convertors |
Spun off from #357
Source
#254 Gives this program
1.25
1.25 Monitor mode:
1.25 TV mode:
1.26
1.26 Monitor mode:
1.26 TV mode
Real TV
On a real TV green + orange look yellow, matching 1.25 more:
Notes:
The text was updated successfully, but these errors were encountered: