Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

double-click issue with AppleWin 1.29.8.0 #750

Closed
Archange427 opened this issue Jan 21, 2020 · 4 comments
Closed

double-click issue with AppleWin 1.29.8.0 #750

Archange427 opened this issue Jan 21, 2020 · 4 comments
Labels
Milestone

Comments

@Archange427
Copy link

Seems I missed the release of the new AppleWin two days ago!

Anyway, issue when I try to open it by double-clicking on a associated file (tested with .dsk and .woz),
I get this:
screenshot

The directory and file name displayed are the name and path of the file I "double-clicked"
Note that the final quote is missing...

And when I click to "OUI" (yes), AppleWin finally opens with the last used file mounted but not the new.
I never had this issue with the previous versions.
Not a dramatic problem but just a little annoying!

@tomcw tomcw added the bug label Jan 21, 2020
@tomcw
Copy link
Contributor

tomcw commented Jan 21, 2020

Thanks for trying the new version and reporting this issue.
I've confirmed it, so will take a look in the coming days.

btw. I really enjoyed your latest Unreeeal Superhero 3! (And I just noticed a new Mad Effect 3... I can't keep up! :-)

@Archange427
Copy link
Author

Thanks Tom.
And don't worry, the pace should be much slower this year!

@tomcw
Copy link
Contributor

tomcw commented Jan 26, 2020

Fixed in fcd1b2a.

Some dev/triage notes:

  • Initially run AppleWin.exe (debug) as "Administrator"
    • this sets up the Registry to point to this specific version of AppleWin to use when double-clicking a .dsk image
  • Add an _ASSERT(0) as the 1st line of WinMain()
  • Double-click a .dsk image (which will trigger the assert)
  • From VS, attach to the AppleWin process
  • now it's possible to debug the state for this double-click action!

This action is registered by AppleWin in RegisterExtensions(), using pValueName = "DiskImage\\shell\\open\\command"

There is a commented out attempt to use applewin.exe -d1 %1, instead of applewin %1... but no explanation why it wasn't used. Ultimately it gets handled by WM_DDE_EXECUTE, so probably it needs to look the same as ddeexec in the Registry (which is just %1).

@tomcw tomcw closed this as completed Jan 26, 2020
@tomcw tomcw added this to the 1.29.9 milestone Jan 26, 2020
@tomcw
Copy link
Contributor

tomcw commented Jan 26, 2020

OK, this new 1.29.9.0 version fixes the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants