Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Charge Quartz Crystal/Fixture lightning effect doesn't render with some resourcepacks #1398

Closed
HanPrower opened this issue May 6, 2015 · 2 comments
Labels
enhancement An enhancement for an existing feature

Comments

@HanPrower
Copy link

I've already stumblingly told thatsIch this on IRC, but as he doesn't have a definitive answer yet I'll post it here so it doesn't get forgotten.

Due to the lightning effect using the first texture on the /assets/minecraft/textures/particle/particles.png spritesheet it doesn't render with some resourcepacks if they haven't centred that texture within the first grid space.

Notable "broken" packs are PureBDcraft in resolutions above 32x and Soartex.

Obviously the easy fix is for those resourcepacks to centre that texture, but Sphax won't retroactively change things nor does he make changes to support mods, sadly.

So, is it possible to add a custom texture for that effect? I understand if it's just not worth the effort, but it'd be nice to get the proper experience when using custom resourcepacks :)

@thatsIch
Copy link
Member

thatsIch commented May 6, 2015

As I already stated, loading a separate texture would have performance-wise an impact. This should not be the go-to solution. (even though its by far the easiest)

@thatsIch thatsIch added the enhancement An enhancement for an existing feature label May 6, 2015
@HanPrower
Copy link
Author

Indeed. After you said that on IRC I should have updated my comment, but I neglected to. Sorry.

Hopefully there's a good fix out there somewhere.

@yueh yueh closed this as completed Jul 17, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement An enhancement for an existing feature
Projects
None yet
Development

No branches or pull requests

3 participants