Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visual glitch with encoded patterns #3161

Closed
bbgott opened this issue Oct 15, 2017 · 6 comments
Closed

Visual glitch with encoded patterns #3161

bbgott opened this issue Oct 15, 2017 · 6 comments
Labels
bug Self explanatory?

Comments

@bbgott
Copy link

bbgott commented Oct 15, 2017

Description

When holding shift to preview what an encoded pattern contains, rather than seeing the preview the pattern just disappears. Letting go of shift makes the pattern reappear

Environment

Tested with multiple mods and with AE2 alone. The behavior is the same

  • Minecraft Version: 1.12.2
  • AE2 Version: rv5-beta-1
  • Forge Version: 1.12.2-14.23.0.2500
@fscan
Copy link
Member

fscan commented Oct 15, 2017

Can you be a bit more specific? What item/recipe is it happening on? Do you have logs, screenshot?

@fscan fscan added the awaiting-feedback Waiting on feedback from the author. Issue will be closed after 7 days of inactivity. label Oct 15, 2017
@bbgott
Copy link
Author

bbgott commented Oct 15, 2017

In this first screenshot I have created an encoded pattern for a chest as an example. You can see the encoded pattern in my inventory.
2017-10-15_10 48 31
When I hold down shift, the encoded pattern is supposed to show me that it is a pattern for a chest by changing to an icon of a chest. Instead, it just disappears.
2017-10-15_10 48 42

I do not see any lines added to the log when it happens.

@fscan
Copy link
Member

fscan commented Oct 15, 2017

Can you reproduce this with any other item then a chest?
I don't know much about the rendering process, but it looks to me the chest item model is rendered with a TESR, so the baked model we get is empty. I don't really know how to fix this, maybe move to a TESR for the encoded pattern? Maybe someone with a bit more insight into this can help.

@fscan fscan added bug Self explanatory? and removed awaiting-feedback Waiting on feedback from the author. Issue will be closed after 7 days of inactivity. labels Oct 15, 2017
@bbgott
Copy link
Author

bbgott commented Oct 15, 2017

Ok, It looks like it may just be models that have a TESR. I tried the same process for making sticks or a furnace and they showed up just fine.
2017-10-15_13 46 59

@Yoosk
Copy link

Yoosk commented Nov 9, 2017

Pretty sure its related to oredictionary enabled in pattern, if it is, they tend to disappear.

@fscan
Copy link
Member

fscan commented Nov 9, 2017

OreDict shouldn't affect the output (rendered item).
I'm sure its because the chest item has a custom renderer (eg not a BakedModel). The good news is that there are not a lot of items that fall under that category.

@yueh yueh closed this as completed Jul 17, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Self explanatory?
Projects
None yet
Development

No branches or pull requests

4 participants