Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
GitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Performance issues on Terminal if Craftable only view is active #3405
Using the ME Network on a Terminal work fine. But If I search for an item and set the view to craftable only. The client will start to lag and after 30 seconds the client ll be kicked from the server.
Switch back View items only or hybrid view brings the client performance back.
The performance comes not from AE2 directly, it looks for me that Biomes O' Plenty are the reason for that.
I'm want to report this issue here, because behavior isn't constant. It appears only an the "craftable only" - not on the Stored Item or Stored Item / Craftable View
In terms of consistency, it should only happen when these conditions are true:
By default we already cache the tooltips for something like that, but it is not done for the craftable only view currently as we cannot touch the underlying itemstack data. So it will be copied, which will not copy the cached tooltip for obvious reasons like memory usage. So it has to fetch it for
We might be able to ease it a bit. BUT this should not solve the actual issue. Which certainly needs further monitoring and should also be reported to any involved mod. E.g. it could actually be caused by JEIIntegration combined with Biomes O' Plenty. Any other mod with a more trivial approach for using tooltips could easily suffer from it.
Edit: Depending on the mentioned mods, it might also only happen when the advanced tooltips are enabled via
Yeah. That was just a guess, hoping that the mod extending the tooltips is smart enough to only enable it when the advanced option is enabled.
Could you try this build?