Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quartz dust as forge quartz dust #4560

Closed
chidori opened this issue Aug 5, 2020 · 9 comments · Fixed by #4568
Closed

Quartz dust as forge quartz dust #4560

chidori opened this issue Aug 5, 2020 · 9 comments · Fixed by #4568
Labels
enhancement An enhancement for an existing feature

Comments

@chidori
Copy link

chidori commented Aug 5, 2020

Looks like nether quartz dust is not considered as forge:dusts. It's little bit frustrating when you can not use quartz dust from other mods (eg Mekanism) trying to smelt it into silicon.

Reasons why it should be considered
Since AE2 can obtain quartz dust only in grinder - it's a pain.

Issued in appliedenergistics2-7.0.0-beta.1.jar

@chidori chidori closed this as completed Aug 5, 2020
@chidori
Copy link
Author

chidori commented Aug 5, 2020

Accidentally closed the issue :(
As temp fix this for this for myself, have added forge:dusts/quartz as ingredient in data/appliedenergistics2/recipes/smelting/silicon.json.
Waiting for the official update.
Thank you.

@chidori chidori reopened this Aug 5, 2020
@shartte
Copy link
Member

shartte commented Aug 5, 2020

We'll leave this to modpack authors. I have no idea how common or uncommon Mekanism quartz is and if its a good fit or not.

@shartte shartte closed this as completed Aug 5, 2020
@chidori
Copy link
Author

chidori commented Aug 5, 2020

@shartte

We'll leave this to modpack authors. I have no idea how common or uncommon Mekanism quartz is and if its a good fit or not.

It's not about Mekanism.
You have added nether quartz dust - an item which obtained through grinder from the minecraft's nether quartz.
Another mod authors can do the same thing - add processing of the original resources to dusts, so it is only about forge recommendations - to make such things in tag domain of forge (in our case forge:dusts).
https://mcforge.readthedocs.io/en/latest/utilities/tags/#conventions

My point is that Grinder - just make dust (eg iron dust from iron), do not add some magic to make quartz dust special - to not become common quartz dust to make silicon from.

I just suggest to add into silicon recipe a forge common domain tag forge:dusts/quartz to make silicon recipe universal for all authors who somehow make nether quartz dust.

All is need - to update recipe to accept forge:dusts/quartz, so the other mod authors if they implement obtaining of quartz dust - it will be OK to make the silicon from it.

{
  "type": "minecraft:smelting",
  "result": {
    "item": "appliedenergistics2:silicon"
  },
  "ingredient": [
    {
      "tag": "appliedenergistics2:dusts/nether_quartz"
    },
    {
      "tag": "forge:dusts/quartz"
    },
    {
      "tag": "appliedenergistics2:dusts/certus_quartz"
    }
  ],
  "experience": 0.0
}

If I still didn't convinced you, can I manually update a mod to play in my single worlds?

@yueh
Copy link
Member

yueh commented Aug 5, 2020

There is simply no forge:dusts/quartz tag we could use. And if you would have read the conventions you linked, than you would know that mods should not pollute the forge domain on their own but make a PR for it to add a new one instead.

So if you consider it is a worthwile contribution to forge to add a tag for quartz dust, feel free to submit a PR and once that is actually available, we can consider using it. Which might depend on various conditions like in case some mod adds a recipe for 1 quartz -> 2 dusts it might break our own doubling and create an infinite loop for quartz or quartz dust.

For now we provide our own tags within our domain for anyone to use as additional option.

@chidori
Copy link
Author

chidori commented Aug 5, 2020

@yueh Ok, reasonable.
Then I dive deeper in that topic.

@XFactHD
Copy link
Collaborator

XFactHD commented Aug 5, 2020

@yueh You should not pollute the Forge domain with new groups but if there is a group for this already (forge:dusts), then you should add to it. This is supported by the examples of brass ingots and cobalt nuggets in the migration section.

@shartte
Copy link
Member

shartte commented Aug 5, 2020

Ooooooooh I thought this was about certus quartz. Yeah we can do that.

@shartte shartte reopened this Aug 5, 2020
@yueh
Copy link
Member

yueh commented Aug 5, 2020

They call tags groups and state that you shouldn't add groups below forge. Either they need to fix their useless docs and state what they want exactly or just remove them and let anyone do what they want and then try and cleanup it later somehow between mods.

@chidori
Copy link
Author

chidori commented Aug 5, 2020

@shartte also, shaped recipes such as quartz glass, and probably other recipes

@shartte shartte added this to the 8.0.0.alpha - 1.16 milestone Aug 5, 2020
@shartte shartte added the enhancement An enhancement for an existing feature label Aug 5, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement An enhancement for an existing feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants