Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a generic capability based P2P tunnel #4666

Closed
3 tasks
yueh opened this issue Aug 31, 2020 · 2 comments
Closed
3 tasks

Add a generic capability based P2P tunnel #4666

yueh opened this issue Aug 31, 2020 · 2 comments
Labels
feature A suggestion for a completely new feature

Comments

@yueh
Copy link
Member

yueh commented Aug 31, 2020

The current P2P tunnels for fluids, forge energy and some degree items are very similar and could be combined into a single class with configurable suppliers for the input and output capabilites.

This should allow for other mods to add custom tunnels, but that will require some careful planning for the requirements,

  • Extract a generic P2P tunnels for capabilities
  • Change TunnelType into an interface make extending easier
  • Add a registry for tunneltypes and input/output capabilities (tentative)
@yueh yueh added the feature A suggestion for a completely new feature label Aug 31, 2020
@yueh yueh added this to the backlog milestone Aug 31, 2020
@wisemars
Copy link

wisemars commented Jan 3, 2021

Why not remove the energy / liquid separation at all and make an imitation of the direct connection of pipes, wires and other things.

@Technici4n
Copy link
Member

Addons can now add p2p tunnels, provided they depend on implementation details. I would say that is fine for now.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature A suggestion for a completely new feature
Projects
None yet
Development

No branches or pull requests

3 participants