Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Meteorites not spawning #5553

Closed
itsdinkd opened this issue Oct 17, 2021 · 4 comments
Closed

Meteorites not spawning #5553

itsdinkd opened this issue Oct 17, 2021 · 4 comments
Labels
bug Self explanatory?

Comments

@itsdinkd
Copy link

Describe the bug

Meteorites are not spawning at all. I am using Terralith mod(datapack) for vanilla biome creation. Though terralith has their own 'vanilla' biomes, regular Minecraft biomes still spawn, which I would imagine Meteorites should be generated in at the very least, as saplings, modded ore, and structures do. structures also spawn in terralith biomes. Not sure why Meteorites are not.

Modlist is attached in pastebin.

How to reproduce the bug

Another Quality Modpack 2 --

Load into game
locate meteorite
not available

Expected behavior

Meteorites generating

Additional details

No response

Which minecraft version are you using?

1.17

On which mod loaders does it happen?

Fabric

Crash log

https://pastebin.com/BD6M4def

@itsdinkd itsdinkd added the bug Self explanatory? label Oct 17, 2021
@shartte
Copy link
Member

shartte commented Oct 17, 2021

Sorry, but there's not a whole lot to say, other than you might want to report this to Fabric.
We just register our structure with all overworld biomes, and if that fails with modded biomes, there's nothing we can do about it.

@shartte shartte closed this as completed Oct 17, 2021
@Technici4n
Copy link
Member

Needs further investigation, it seems this might be on our end given that other modded things seem to work.

@Technici4n Technici4n reopened this Oct 28, 2021
@shartte
Copy link
Member

shartte commented Oct 28, 2021

Confirmed to be the case if a custom datapack chunk generator is used. This was somewhat by design at some point in the past. The idea was: if a datapack chunk generator is used, it should explicitly state the structure configs.

We're going to always add ours now, instead. If ppl want to disable meteorites, they already got other options.

@itsdinkd
Copy link
Author

@Technici4n I must report that Meteorites stopped spawning. It worked after the fix, but then I checked the other day as I was curious and wanted to visit one, and got the message from /locate that it could not be found.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Self explanatory?
Projects
None yet
Development

No branches or pull requests

3 participants