Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Cannot make custom input working #48

Closed
1 task done
patzaw opened this issue Dec 4, 2023 · 4 comments
Closed
1 task done

[Bug]: Cannot make custom input working #48

patzaw opened this issue Dec 4, 2023 · 4 comments
Labels
bug Something isn't working

Comments

@patzaw
Copy link

patzaw commented Dec 4, 2023

Guidelines

  • I agree to follow this project's Contributing Guidelines.

Project Version

0.2.0

Platform and OS Version

No response

Existing Issues

No response

What happened?

Hello

I've tried to run the example provided in the package site home page (https://appsilon.github.io/reactable.extras/index.html). The custom inputs do not appear as expected. When I try to click on a cell that what supposed to be a button nothing happen.
I've tried on different systems: RHEL7 rstudio server, windows10 rstudio desktop and posit cloud. Here is the link to the posit cloud project : https://posit.cloud/content/7196779.
My main web browser is Microsoft Edge (Version 119.0.2151.93).

I can't see what I'm doing wrong...

Thanks for sharing this promising package by the way.

Steps to reproduce

  1. Go to https://posit.cloud/content/7196779
  2. Run the shiny app in the shiny_test folder

Expected behavior

The table with the custom input displayed correctly and functional.

Attachments

No response

Screenshots or Videos

No response

Additional Information

No response

@patzaw patzaw added the bug Something isn't working label Dec 4, 2023
@jakubnowicki
Copy link
Member

Hi @patzaw
Most probably, this is related to a recent change in htmlwidgets@1.6.3 that breaks reactable::JS function. We are waiting for the new version of reactR to be released on CRAN - this should fix the problem. In the meantime, as a workaround, you can try downgrading htmlwidgets to version 1.6.2 or installing the development version of reactR (remotes::install_github("react-R/reactR@develop")).

@patzaw
Copy link
Author

patzaw commented Dec 4, 2023

I've just installed the development version of reactR and indeed it works now.
Thanks @jakubnowicki for the efficient workaround.
Should I close the issue?

@jakubnowicki
Copy link
Member

Please leave it open; I'll close it once the new version of reactR is released.

@jakubnowicki
Copy link
Member

htmlwidgets@1.6.4 reverted the breaking change, which fixed the issue with custom inputs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants